Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: Favicon not working #47

Open
Adeesh-devanand opened this issue Oct 6, 2021 · 5 comments
Open

Website: Favicon not working #47

Adeesh-devanand opened this issue Oct 6, 2021 · 5 comments
Assignees
@Adeesh-devanand
Labels
bug Something isn't working good first issue Good for newcomers SODACODE2022 SODALOW website website related

Comments

@Adeesh-devanand
Copy link
Contributor

Can anyone who has previously used jekyll, mmistakes theme please help fix the website favicon.

Here's the link to the config.yml file

Thank you for your help!!
@gopaddle-io gopaddle-io added bug Something isn't working good first issue Good for newcomers website website related labels Oct 6, 2021
@gopaddle-io gopaddle-io added the hacktoberfest Ready to work on label Oct 6, 2021
@gopaddle-io gopaddle-io added SODALOW and removed hacktoberfest Ready to work on labels Feb 25, 2022
@gopaddle-io
Copy link
Owner

Please send pull requests to SODACODE-2022

@aimanfatima
Copy link

Can I fix this? I believe only favicon.ico is missing in the assets/images folder.
<link rel="shortcut icon" type="image/x-icon" href="{{ site.baseurl }}/assets/images/favicon.ico"> https://github.com/gopaddle-io/configurator/blob/329f3c0ee731422be206a2a936de875226f6e67a/docs/_includes/head-custom.html
I've generated a favicon using https://realfavicongenerator.ne which I can place in the above folder, and it should work I guess?
The favicon generated looks like this -
image

@gopaddle-io
Copy link
Owner

Yes, you are right. We need a favicon as per the sample you had shared.

@Adeesh-devanand
Copy link
Contributor Author

Hey @aimanfatima, sure go ahead and send a pull request. I will test it on my environment before merging the code.

@aimanfatima aimanfatima mentioned this issue Mar 16, 2022
Closed
@aimanfatima
Copy link

@Adeesh-devanand created a PR
#91
please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adeesh-devanand Adeesh-devanand

Labels
bug Something isn't working good first issue Good for newcomers SODACODE2022 SODALOW website website related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aimanfatima @gopaddle-io @Adeesh-devanand