Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old tag in goreportcard.com #388

Open
smutel opened this issue Jun 9, 2022 · 5 comments
Open

Old tag in goreportcard.com #388

smutel opened this issue Jun 9, 2022 · 5 comments

Comments

@smutel
Copy link

smutel commented Jun 9, 2022

Hello,

I don't understand why a old tag of my repo is reported in goreportcard.com ?

https://goreportcard.com/report/github.com/smutel/terraform-provider-netbox => v1.3.0

This tag has been released one year ago ...

How to use the last tag ?

Thanks.

@shawnps
Copy link
Contributor

shawnps commented Jun 9, 2022

Hi @smutel

I think Go treats anything above v1 differently:

https://go.dev/doc/modules/release-workflow#breaking

You may be able to update your go.mod to:

module github.com/smutel/terraform-provider-netbox/v4

@smutel
Copy link
Author

smutel commented Jun 9, 2022

I updated the go.mod and I click on the refresh button.
However the version is still 1.3.0 in goreportcard.com.

@shawnps
Copy link
Contributor

shawnps commented Jun 9, 2022

@smutel Not totally sure but you may need a v4 dir:

https://research.swtch.com/vgo-module

In this case, v2.0.0 is created not by forking the whole tree into a separate branch but by copying it into a subdirectory. Again the go.mod must be updated to say "my/thing/v2". Afterward, v1.x.x tags pointing at commits address the files in the root directory, excluding v2/, while v2.x.x tags pointing at commits address the files in the v2/ subdirectory only.

We are basically doing the same thing as pkg.go.dev, and you can see they also show v1.3.0 for your module.

@smutel
Copy link
Author

smutel commented Sep 9, 2022

Is-it possible to specify a branch or a tag when we ask goreportcard.com to generate a report ?

@apprehensions
Copy link

still facing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants