fix: ROOT_TASKFILE when Entrypoint is not set

[vmaerten]

fixes #1706

[vmaerten]

I thought put a default value here

	entrypoint := flags.Entrypoint
	if entrypoint == "" {
		entrypoint = "Taskfile.yml"
	}

but it would break

func getDefaultDir(entrypoint, dir string) string {
	// If the entrypoint and dir are empty, we default the directory to the current working directory
	if dir == "" {
		if entrypoint == "" {
			wd, err := os.Getwd()
			if err != nil {
				return ""
			}
			dir = wd
		}
		return dir
	}

	// If the directory is set, ensure it is an absolute path
	var err error
	dir, err = filepath.Abs(dir)
	if err != nil {
		return ""
	}

	return dir
}

I don't know which solution do you prefer

[andreynering]

Actually, the default is not necessarily Taskfile.yml. We have a list of 8 possible file names that are detected and work by default:

task/taskfile/taskfile.go

Lines 19 to 28 in 88b0950

	defaultTaskfiles = []string{
	"Taskfile.yml",
	"taskfile.yml",
	"Taskfile.yaml",
	"taskfile.yaml",
	"Taskfile.dist.yml",
	"taskfile.dist.yml",
	"Taskfile.dist.yaml",
	"taskfile.dist.yaml",
	}

In the taskfile package we have code that will try to detect it. It may be a bit tricky, but in order to be reliable we need to reuse that code somehow.

[vmaerten]

I totally agree I missed that part
What I did here, export taskfile.go in a new package in order to have access to DefaultTaskfiles
Then I check (as it's done on Exists func) if the file exist. I did not reuse the Exist function because we do not want to log smth

[vmaerten]

I checked and it works with Taskfile.dist.yml