Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify if push event is for a pull request merge without additional API calls #24

Open
adityasaky opened this issue Nov 11, 2024 · 0 comments

Comments

@adityasaky
Copy link
Member

Currently, the push event handler creates an RSL entry for the reference in question. As GitHub sends a push event and a pull request event when a PR is merged, the push event handler uses the API to identify if the pushed commit is part of any pull requests that were merged. If so, an RSL entry is not created because the pull request handler takes care of it instead. This issue is to discuss if we can achieve this without the additional API call, especially since the API response may not indicate that the PR was merged (there may be a delay before the change in status is reflected in the API response).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant