Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement config map #345

Open
gsantopaolo opened this issue Jul 11, 2024 · 4 comments
Open

implement config map #345

gsantopaolo opened this issue Jul 11, 2024 · 4 comments
Assignees
Labels

Comments

@gsantopaolo
Copy link
Contributor

config map shall be implemented server side

  • API to be exposed to the client, paged list by file (see config folder), insert, edit, update, delete, search
  • necessary business logic to read and write config maps and or env file (shall be cross-compatible doker/k8

If you deen you can contact Noel for k8/config map

@apCognixCh
Copy link
Contributor

Need to be clarified :

  1. What user role will have ability to call configmap endpoints ?
    ( in current implementation all users that registered in cognix have role admin for they tenant )
    We do not have any user that have permission for configure working environment.

  2. For applying changes in configmap we need to restart containers that depends on this changes.
    I need research time or instruction how I can do that from inside of pod ( I hope this package provide this ability https://github.com/kubernetes/client-go)
    and from docker container ( I need time for research )

  3. Do you need to have a separate one container for management k8s and docker or do implement this functionality in api container ?

@apCognixCh
Copy link
Contributor

According to figma design is not clear what configMap ( or .env file) we should manage.
curently we use several configMaps for different services. ?

@gsantopaolo

@gsantopaolo
Copy link
Contributor Author

  1. super admin
  2. pod restart its out of the scope of this feature
  3. separate container
  4. For the use it shall be transparent under the hood if we are running Docker we change our .env files. If we are running on K8 we change the config map. I would like to have separate files in config map as well, ask noel

@apCognixCh
Copy link
Contributor

apCognixCh commented Jul 12, 2024

@gsantopaolo

implement new container for
edit .env files in docker-compose environment .
edit configMap in k8s cluster

endpoints
[GET] /api/config-map/{filename} - return content of config map
[POST] /api/config-map/{filename} - add or update key - value pair in configmap
[DELETE] / api/config-map/{filename}/{key} - remove key- value pair from configmap.

Estimation time : 16 - 20 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants