Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: CI duble testing same domain #372

Open
spirillen opened this issue Jun 25, 2024 · 5 comments
Open

BUG: CI duble testing same domain #372

spirillen opened this issue Jun 25, 2024 · 5 comments
Assignees
@funilrys
Labels
bug

Comments

@spirillen
Copy link
Contributor

spirillen commented Jun 25, 2024 •
edited
Loading

Description

To understand my question/observation we have to look at these to GHA

  1. https://github.com/mypdns/matrix/actions/runs/9656304178/job/26633593189#step:6:166
  2. https://github.com/mypdns/matrix/actions/runs/9656341145/job/26633690610#step:6:166

As you now can see, then the two CI are testing the same domains. Now why is this weird, the sources are the same, yes. but they are pushing the test results to a central mariadb.

Configuration

Please see https://github.com/mypdns/matrix/blob/e42eba13fb4b7da22c10408362e9891c5d8fd0df/.pyfunceble/.PyFunceble.overwrite.yaml

Reproduction

  1. Run the CI with an external DB

Expected behavior

I would have expected that we don't keep testing the same records again and again as we uses a central DB to store the results. As the one CI started a couple of minutes earlier.

Screenshots

Not needed

Versions

OS: ubuntu-latest

Python Version: 3.12

PyFunceble Version: 4.2.4-dev

Additional context

I will suggest a workflow like

  1. -c --preload = Read date from source
  2. write new data to db
  3. Read data to test
  4. Test that data
  5. Write test result to DB
  6. repeat from 3 till the end
@spirillen spirillen added the bug label Jun 25, 2024
@spirillen
Copy link
Contributor Author

And a 3rd run, the same data again

https://github.com/mypdns/matrix/actions/runs/9656558435/job/26634259933#step:6:167

@funilrys
Copy link
Owner

I think you need to activate the cli_testing.autocontinue option.
We disabled it as default a few years back. It is only active when you actively want it.

spirillen added a commit to mypdns/matrix that referenced this issue Sep 23, 2024
@spirillen
autocontinue: yes
7dc1d2d 
Ref funilrys/PyFunceble#372

Signed-off-by: @spirillen ${revision}

---------

Thanks to Jetbrains, for Sponsoring My Privacy DNS with their Open Source software licenses.

Their software helps us develop and maintain My Privacy DNS and other project as they made writing code easier.
@spirillen
Copy link
Contributor Author

Changed in mypdns/matrix@7dc1d2d now we just waits

@spirillen
Copy link
Contributor Author

It comes to my mind while I was eating... This should to my mind not have any relations to the -c | --continue setting, it is purely related to the --bdr as it was already tested within this time frame

Relates to #145, #168 & #383 am I right?

@spirillen
Copy link
Contributor Author

The -c didn't change the result of this issue...

  1. test run https://github.com/mypdns/matrix/actions/runs/10999209893/job/30538882122#step:6:167
  2. test run https://github.com/mypdns/matrix/actions/runs/11000119117/job/30541818884#step:6:164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@funilrys funilrys

Labels
bug
Projects
PyFunceble Backlog
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@funilrys @spirillen