Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vulnerability] Exposed Firebase Credentials #1772

Open
Shauryae1337 opened this issue Oct 27, 2024 · 7 comments
Open

[Vulnerability] Exposed Firebase Credentials #1772

Shauryae1337 opened this issue Oct 27, 2024 · 7 comments

Comments

@Shauryae1337
Copy link

https://github.com/fireship-io/fireship.io/blob/master/app/util/firebase.ts

Please remove the following firebase key as it can lead to unauthorized access.
The key is valid .

image

@ViktorPopp
Copy link

ViktorPopp commented Nov 7, 2024

Maybe you shoukd not show this publicly. There is AI bots around the internet searching for stuff like this. I would recommend deleting the issue and contacting Fireship.io

@AyushmanOfficial
Copy link

Guys it's been a month? Is this issue fixed

@ViktorPopp
Copy link

Then close it

@void-anonymous
Copy link

I don't mean to be rude, but this guy is selling coding courses and doesn't even know that credentials should never be directly included in the code. Always use environment variables, even in the local environment.

@AyushmanOfficial
Copy link

I mean uhh you're right and it could've been a mistake

@jits
Copy link

jits commented Nov 23, 2024

It's fine to make these credentials public (as long as you secure the Firebase services via their respective rules systems, and other configuration). See: https://firebase.google.com/docs/projects/api-keys

@AyushmanOfficial
Copy link

AyushmanOfficial commented Nov 23, 2024

It's fine to make these credentials public (as long as you secure the Firebase services via their respective rules systems, and other configuration). See: https://firebase.google.com/docs/projects/api-keys

You're right too! If he has security rules i don't think someone can misuse it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants