Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotus Node and Miner v1.32.0 Release #12750

Open
54 of 93 tasks
BigLep opened this issue Dec 3, 2024 · 5 comments
Open
54 of 93 tasks

Lotus Node and Miner v1.32.0 Release #12750

BigLep opened this issue Dec 3, 2024 · 5 comments
Assignees
Labels

Comments

@BigLep
Copy link
Member

BigLep commented Dec 3, 2024

πŸ˜Άβ€πŸŒ« Meta

🚒 Estimated shipping date

Candidate Expected Release Date Release URL
RC1 Week of 2024-12-05 https://github.com/filecoin-project/lotus/releases/tag/v1.32.0-rc1 https://github.com/filecoin-project/lotus/releases/tag/miner%2Fv1.32.0-rc1
RC2 Week of 2024-12-09 https://github.com/filecoin-project/lotus/releases/tag/v1.32.0-rc2 https://github.com/filecoin-project/lotus/releases/tag/miner%2Fv1.32.0-rc2
Stable (non-RC) Week of 2024-12-18 (estimate)

πŸͺ’ Dependencies for releases

Note

  1. This is the set of changes that need to make it in for a given RC. This is effectively the set of changes to cherry-pick from master.
  2. They can be checked as done once they land in master.
  3. They are presented here for quick reference, but backporting is tracked in each Release Checklist.

rc1

rc2

Stable Release (non-RC)

βœ… Release Checklist

⬅️ Before RC1

Section

🏎️ RCs

rc1

Section

[!IMPORTANT]
These PRs should be done in and target the release/v1.32.0 or release/miner/v1.32.0 branch.

Backport PR for rc1

  • All explicitly tracked items from Dependencies for releases have landed

Release PR for rc1

  • Update the version string(s) in build/version.go to one ending with '-rc1'.
    • Ensure to update NodeBuildVersion
    • Ensure to update MinerBuildVersion
  • Run make gen && make docsgen-cli to generate documentation
  • Create a draft PR with title build: release Lotus Node and Miner v1.32.0-rc1
  • Changelog prep
    • Go to the releases page and copy the auto-generated release notes into the CHANGELOG
    • Perform editorial review (e.g., callout breaking changes, new features, FIPs, actor bundles)
    • (network upgrade) Specify whether the Calibration or Mainnet upgrade epoch has been specified or not yet.
      • Example where these weren't specified yet: PR #12169
    • Ensure no missing content when spot checking git history
      • Example command looking at git commits: git log --oneline --graph vA.B.C.., where A.B.C correspond to the previous release.
      • Example GitHub UI search looking at merged PRs into master: https://github.com/filecoin-project/lotus/pulls?q=is%3Apr+base%3Amaster+merged%3A%3EYYYY-MM-DD
      • Example gh cli command looking at merged PRs into master and sorted by title to group similar areas (where YYYY-MM-DD is the start search date): gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, .mergedAt, .author.login, .title] | @tsv' | sort -k4
    • Update the PR with the commit(s) made to the CHANGELOG
  • Mark the PR "ready for review" (non-draft)
  • Merge the PR
    • Merging the PR will trigger a CI run that will build assets, attach the assets to the GitHub release, publish the GitHub release, and create the corresponding git tag.
  • Update 🚒 Estimated shipping date table
  • Comment on this issue announcing the RC

Testing for rc1

[!NOTE]
Link to any special steps for testing releases beyond ensuring CI is green. Steps can be inlined here or tracked elsewhere.

rc2

Section

[!IMPORTANT]
These PRs should be done in and target the release/v1.32.0 or release/miner/v1.32.0 branch.

Backport PR for rc2

Release PR for rc2

  • Update the version string(s) in build/version.go to one ending with '-rc2'.
    • Ensure to update NodeBuildVersion
    • Ensure to update MinerBuildVersion
  • Run make gen && make docsgen-cli to generate documentation
  • Create a draft PR with title build: release Lotus Node and Miner v1.32.0-rc2
  • Changelog prep
    • Go to the releases page and copy the auto-generated release notes into the CHANGELOG
    • Perform editorial review (e.g., callout breaking changes, new features, FIPs, actor bundles)
    • (network upgrade) Specify whether the Calibration or Mainnet upgrade epoch has been specified or not yet.
      • Example where these weren't specified yet: PR #12169
    • Ensure no missing content when spot checking git history
      • Example command looking at git commits: git log --oneline --graph vA.B.C.., where A.B.C correspond to the previous release.
      • Example GitHub UI search looking at merged PRs into master: https://github.com/filecoin-project/lotus/pulls?q=is%3Apr+base%3Amaster+merged%3A%3EYYYY-MM-DD
      • Example gh cli command looking at merged PRs into master and sorted by title to group similar areas (where YYYY-MM-DD is the start search date): gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, .mergedAt, .author.login, .title] | @tsv' | sort -k4
    • Update the PR with the commit(s) made to the CHANGELOG
  • Mark the PR "ready for review" (non-draft)
  • Merge the PR
    • Merging the PR will trigger a CI run that will build assets, attach the assets to the GitHub release, publish the GitHub release, and create the corresponding git tag.
  • Update 🚒 Estimated shipping date table
  • Comment on this issue announcing the RC

Testing for rc2

[!NOTE]
Link to any special steps for testing releases beyond ensuring CI is green. Steps can be inlined here or tracked elsewhere.

rcX

Section

[!IMPORTANT]
These PRs should be done in and target the release/v1.32.0 or release/miner/v1.32.0 branch.

Backport PR for rcX

  • All explicitly tracked items from Dependencies for releases have landed
  • Backported everything with the "backport" label
  • Removed the "backport" label from all backported PRs (no "backport" issues)
  • Create a PR with title build: backport changes for Node and Miner v1.32.0-rcX
    • Link to PR:
  • Merge PR

Release PR for rcX

  • Update the version string(s) in build/version.go to one ending with '-rcX'.
    • Ensure to update NodeBuildVersion
    • Ensure to update MinerBuildVersion
  • Run make gen && make docsgen-cli to generate documentation
  • Create a draft PR with title build: release Lotus Node and Miner v1.32.0-rcX
    • Link to PR:
    • Opening a PR will trigger a CI run that will build assets, create a draft GitHub release, and attach the assets.
  • Changelog prep
    • Go to the releases page and copy the auto-generated release notes into the CHANGELOG
    • Perform editorial review (e.g., callout breaking changes, new features, FIPs, actor bundles)
    • (network upgrade) Specify whether the Calibration or Mainnet upgrade epoch has been specified or not yet.
      • Example where these weren't specified yet: PR #12169
    • Ensure no missing content when spot checking git history
      • Example command looking at git commits: git log --oneline --graph vA.B.C.., where A.B.C correspond to the previous release.
      • Example GitHub UI search looking at merged PRs into master: https://github.com/filecoin-project/lotus/pulls?q=is%3Apr+base%3Amaster+merged%3A%3EYYYY-MM-DD
      • Example gh cli command looking at merged PRs into master and sorted by title to group similar areas (where YYYY-MM-DD is the start search date): gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, .mergedAt, .author.login, .title] | @tsv' | sort -k4
    • Update the PR with the commit(s) made to the CHANGELOG
  • Mark the PR "ready for review" (non-draft)
  • Merge the PR
    • Merging the PR will trigger a CI run that will build assets, attach the assets to the GitHub release, publish the GitHub release, and create the corresponding git tag.
  • Update 🚒 Estimated shipping date table
  • Comment on this issue announcing the RC
    • Link to issue comment:

Testing for rcX

[!NOTE]
Link to any special steps for testing releases beyond ensuring CI is green. Steps can be inlined here or tracked elsewhere.

Stable Release (non-RC)

Section

[!IMPORTANT]
These PRs should be done in and target the release/v1.32.0 or release/miner/v1.32.0 branch.

Backport PR for Stable Release (non-RC)

  • All explicitly tracked items from Dependencies for releases have landed
  • Backported everything with the "backport" label
  • Removed the "backport" label from all backported PRs (no "backport" issues)
  • Create a PR with title build: backport changes for Node and Miner v1.32.0
    • Link to PR:
  • Merge PR

Release PR for Stable Release (non-RC)

  • Update the version string(s) in build/version.go to one *NOT ending with 'rcX'.
    • Ensure to update NodeBuildVersion
    • Ensure to update MinerBuildVersion
  • Run make gen && make docsgen-cli to generate documentation
  • Create a draft PR with title build: release Lotus Node and Miner v1.32.0
    • Link to PR:
    • Opening a PR will trigger a CI run that will build assets, create a draft GitHub release, and attach the assets.
  • Changelog prep
    • Go to the releases page and copy the auto-generated release notes into the CHANGELOG
    • Perform editorial review (e.g., callout breaking changes, new features, FIPs, actor bundles)
    • (network upgrade) Ensure the Mainnet upgrade epoch is specified.
    • Ensure no missing content when spot checking git history
      • Example command looking at git commits: git log --oneline --graph vA.B.C.., where A.B.C correspond to the previous release.
      • Example GitHub UI search looking at merged PRs into master: https://github.com/filecoin-project/lotus/pulls?q=is%3Apr+base%3Amaster+merged%3A%3EYYYY-MM-DD
      • Example gh cli command looking at merged PRs into master and sorted by title to group similar areas (where YYYY-MM-DD is the start search date): gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, .mergedAt, .author.login, .title] | @tsv' | sort -k4
    • Update the PR with the commit(s) made to the CHANGELOG
  • Mark the PR "ready for review" (non-draft)
  • Merge the PR
    • Merging the PR will trigger a CI run that will build assets, attach the assets to the GitHub release, publish the GitHub release, and create the corresponding git tag.
  • Update 🚒 Estimated shipping date table
  • Comment on this issue announcing the RC
    • Link to issue comment:

Testing for Stable Release (non-RC)

[!NOTE]
Link to any special steps for testing releases beyond ensuring CI is green. Steps can be inlined here or tracked elsewhere.

➑ Post-Release

Section

❀️ Contributors

See the final release notes!

⁉️ Do you have questions?

Leave a comment in this ticket!

@BigLep BigLep added the TPM label Dec 3, 2024
@github-project-automation github-project-automation bot moved this to πŸ“Œ Triage in FilOz Dec 3, 2024
@BigLep BigLep pinned this issue Dec 3, 2024
@BigLep
Copy link
Member Author

BigLep commented Dec 3, 2024

Created using #12749 with ./release create-issue --create-on-github --type both --tag 1.32.0 --level minor --network-upgrade 25 --rc1-date "Week of 2024-12-02" --stable-date "Week of 2024-12-16"

@sin3point14
Copy link

The upgrade announcement says:

The Filecoin CalibrationNet will undergo an upgrade to network version 25, codenamed "Teep 🦡", at epoch 2235454, on 2024-12-16T23:00:00Z.

This issue says:

Stable (non-RC) Week of 2024-12-16 (estimate)

https://github.com/filecoin-project/lotus/releases/tag/miner/v1.32.0-rc1 says:

This release candidate does NOT set the mainnet network upgrade epoch. It will be added in the final release (expected December 18th).

I think the 18 Dec in the release notes is a typo, since it lies after 16th. But even in this issue, the stable release is expected to be on 16 dec which is the same day as the upgrade... which imo gives very little time for node operators to perform the upgrade, unless I am misunderstanding something

@rjan90
Copy link
Contributor

rjan90 commented Dec 5, 2024

Hey @sin3point14!

Thanks for catching some of the inconsistencies. I have updated the Stable (non-RC) date in this issue to be 2024-12-18. It is only the Calibration network (testnet) that will be upgraded on 2024-12-16, for which one needs to update to the https://github.com/filecoin-project/lotus/releases/tag/v1.32.0-rc1 release.

The stable release is expected to be published on 2024-12-18 with the Mainnet upgrade epoch in the middle of January 2025. So to summarise:

  • December 4th: Lotus v1.32.0-rc1 with Calibration upgrade epoch set
  • December 16th: Calibration Network Upgrade
  • December 18th: Lotus v1.32.0 with Mainnet upgrade set (TBD)
  • Expected Mid January 2025: Mainnet Network 25 upgrade / F3 activation

Did that clarify the different dates?

@rjan90
Copy link
Contributor

rjan90 commented Dec 5, 2024

2024-12-05 Update

The first release candidates which has the network upgrade epoch set for the Calibration testnet to Epoch 2235454 - 2024-12-16T23:00:00Z has been published here:

@rjan90
Copy link
Contributor

rjan90 commented Dec 13, 2024

2024-12-12 Update

β€Ό Please see updated announcement with regards to the cancellation of the nv25 network upgrade on Calibration here: filecoin-project/community#74 (reply in thread)

We have published Lotus v1.32.0-rc2 which cancels the Calibration network upgrade here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ⌨️ In Progress
Development

No branches or pull requests

3 participants