Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow React 19 in peerDependencies in Docusaurus v3 #10750

Open
1 of 2 tasks
tats-u opened this issue Dec 9, 2024 · 6 comments
Open
1 of 2 tasks

Allow React 19 in peerDependencies in Docusaurus v3 #10750

tats-u opened this issue Dec 9, 2024 · 6 comments
Labels
proposal This issue is a proposal, usually non-trivial change

Comments

@tats-u
Copy link
Contributor

tats-u commented Dec 9, 2024

Have you read the Contributing Guidelines on issues?

Motivation

React 19 was stabilized.
#9985 will be fixed once you update React to 19.
#10079 was fixed in Docusaurus 3.3, but are there any remaining problems preventing Docusaurus from combined with React 19?

Self-service

  • I'd be willing to do some initial work on this proposal myself.
@tats-u tats-u added proposal This issue is a proposal, usually non-trivial change status: needs triage This issue has not been triaged by maintainers labels Dec 9, 2024
@tats-u
Copy link
Contributor Author

tats-u commented Dec 9, 2024

If we don't allow React 19 in Docusaurus 3.x, we will have to clarify "You may have to patch react-dom to prevent it from mixing NUL into output HTML." in the migration guide from 2.x.

@Jordaneisenburger
Copy link

I think it will take a while before we get react 19 support unfortunately: #10745

@tats-u
Copy link
Contributor Author

tats-u commented Dec 10, 2024

I'm glad to know it but it's disappointing that React 19 is going to be supported only by Docusaurus v4.

@slorber
Copy link
Collaborator

slorber commented Dec 10, 2024

Considering the low amount of changes required to support React 19, I think it should be possible to support both React 18 and React 19 in Docusaurus v3.

I'd see if we can allow React 19 in Docusaurus v3.7. If possible and for dogfooding, I'd like new initialized sites and our own website to also use React 19 asap.

The breaking change for Docusaurus v4 is to require React 19, so that we can start using new features that are not available in v18.

@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Dec 10, 2024
@Jordaneisenburger
Copy link

Considering the low amount of changes required to support React 19, I think it should be possible to support both React 18 and React 19 in Docusaurus v3.

I'd see if we can allow React 19 in Docusaurus v3.7. If possible and for dogfooding, I'd like new initialized sites and our own website to also use React 19 asap.

The breaking change for Docusaurus v4 is to require React 19, so that we can start using new features that are not available in v18.

That would be amazing, main reason for me is that we use Docusaurus in a NX repo and get a bunch of peerdep headaces from Docusaurus atm as we're upgrading our other apps to React 19

@tats-u
Copy link
Contributor Author

tats-u commented Dec 10, 2024

The breaking change for Docusaurus v4 is to require React 19

Sorry for misunderstanding.

I think it should be possible to support both React 18 and React 19 in Docusaurus v3.

I'd see if we can allow React 19 in Docusaurus v3.7.

Thank you for considering the backport.

@tats-u tats-u changed the title Allow React 19 in peerDependencies Allow React 19 in peerDependencies in Docusaurus v3 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal This issue is a proposal, usually non-trivial change
Projects
None yet
Development

No branches or pull requests

3 participants