Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Issue from Unshaded Dependencies #171

Open
michaelli321 opened this issue Jul 23, 2021 · 0 comments · May be fixed by #237
Open

Build Issue from Unshaded Dependencies #171

michaelli321 opened this issue Jul 23, 2021 · 0 comments · May be fixed by #237

Comments

@michaelli321
Copy link

Hello! I'm trying to incorporate this package in my project but I'm having some issues building my project because of unshaded dependencies. My project has some of the same dependencies in this project, such as Opencensus, which causes build issues since both classes end up in the classpath. Would you be able to shade the dependencies or what would you suggest I do to fix this? Thanks!
sfc-gh-pbennes added a commit to sfc-gh-pbennes/java-control-plane that referenced this issue May 13, 2022
@sfc-gh-pbennes
Use the public maven central relase of io.opencensus:opencensus-proto
0997fcf 
This fixes an issue of duplicate and possibly incompatible classes for
io.opencensus classes. If a project includes both opencensus-proto and
api dependencies, there will be duplicate classes for opencensus-proto
classes on the class path. This is because:
- these classes are vendored in this repo but not declared in the pom
- the version of opencensus-proto used is not a public release in maven central

Fixes envoyproxy#171

Signed-off-by: Preston Bennes <[email protected]>
@sfc-gh-pbennes sfc-gh-pbennes linked a pull request May 13, 2022 that will close this issue
Open
sfc-gh-pbennes added a commit to sfc-gh-pbennes/java-control-plane that referenced this issue May 13, 2022
@sfc-gh-pbennes
Use the public maven central relase of com.google.api.grpc:proto-goog…
b0d8ad6 
…le-common-protos

This fixes an issue of duplicate and possibly incompatible classes for
com/google/api and com/google/rpc proto generated classes. If a project
includes both api and proto-google-common-protos dependencies, there
will be duplicate classes on the class path. This is because:
- these classes are vendored in this repo but not declared in the pom
- the version of proto-google-common-protos used is not a public release in maven central

Similar to the issue in envoyproxy#171 that envoyproxy#237 will fix.

Signed-off-by: Preston Bennes <[email protected]>
@sfc-gh-pbennes sfc-gh-pbennes mentioned this issue May 13, 2022
Open
@hisener hisener mentioned this issue Jul 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@michaelli321