Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring envoyproxy infra attributes in the Helm chart #4764

Open
Xunzhuo opened this issue Nov 22, 2024 · 1 comment
Open

Support configuring envoyproxy infra attributes in the Helm chart #4764

Xunzhuo opened this issue Nov 22, 2024 · 1 comment
Assignees
Labels
area/config Issues related to config management, e.g. Config Manager, Config Sources, etc. kind/enhancement New feature or request
Milestone

Comments

@Xunzhuo
Copy link
Member

Xunzhuo commented Nov 22, 2024

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

In vendor, it has some scenarios for configuring envoyproxies attributes. It would be nice to configure all the envoyproxy knobs in the helm chart.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@Xunzhuo Xunzhuo added the triage label Nov 22, 2024
@zhaohuabing zhaohuabing added area/config Issues related to config management, e.g. Config Manager, Config Sources, etc. kind/enhancement New feature or request and removed triage labels Nov 22, 2024
@arkodg
Copy link
Contributor

arkodg commented Nov 23, 2024

+1 to this, a envoyProxy / envoyProxyTemplate field could be added to

type Gateway struct {

This now introduces 3 levels of EnvoyProxy configuration (EnvoyGateway, EnvoyProxy attached to GatewayClass, EnvoyProxy attached to Gateway)
The current merge Strategy is Replace and most specific one wins, so if the admin set the image value at top level it will be overridden if any other value is set in the lower level EnvoyProxy (all fields are replaced today)

There is the Merge Strategy option tracked with #1934

@Xunzhuo Xunzhuo self-assigned this Nov 25, 2024
@zhaohuabing zhaohuabing added the help wanted Extra attention is needed label Nov 25, 2024
@arkodg arkodg removed the help wanted Extra attention is needed label Nov 25, 2024
@arkodg arkodg added this to the v1.3.0-rc.1 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues related to config management, e.g. Config Manager, Config Sources, etc. kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants