Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in adonis4.x in passing properties to middleware fixes #22 #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erikkallen
Copy link

This is my current workaround the syntax might not be as pretty but is does work let me know if this is a viable option

@coveralls
Copy link

coveralls commented Aug 29, 2018

Coverage Status

Coverage increased (+0.1%) to 87.375% when pulling 3a3ebc7 on erikkallen:master into fc179d4 on enniel:master.

Copy link

@cmelgarejo cmelgarejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same issue, awesome @erikkallen 👍

Copy link

@cmelgarejo cmelgarejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually after trying again, you just have to use or and and instead of || and && in the expressions, no need to do another replacement! 😮
Just change the readme! (or just remove the commas and replace with spaces 😄 )

@erikkallen
Copy link
Author

@cmelgarejo you are right that looks a lot better too! I have updated the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants