Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove end slash from rootPath / rootUri / workspaceFolders #963

Open
zulus opened this issue Apr 12, 2024 · 0 comments
Open

Remove end slash from rootPath / rootUri / workspaceFolders #963

zulus opened this issue Apr 12, 2024 · 0 comments

Comments

@zulus
Copy link
Contributor

zulus commented Apr 12, 2024

While fighting with eclipse-wildwebdeveloper/wildwebdeveloper#1520 and analyzing different behaviors in Typescript LS between VScode and Eclipse, I realized that typescript is not able to correctly find projectRootPath.

It's because rootPath/rootUri/workspaceFolders always ends with "/" (at least on mac). So when Typescript LS search for projectRoot by checking (in loop) if documentPath starts with rootPath + DIR_SEPARATOR is not able to find it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zulus