Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonParserImpl's skipArray() and skipObject() not working according to jakarta.json.stream.JsonParser description #112

Open
api-from-the-ion opened this issue Nov 13, 2023 · 0 comments
Open

JsonParserImpl's skipArray() and skipObject() not working according to jakarta.json.stream.JsonParser description #112

api-from-the-ion opened this issue Nov 13, 2023 · 0 comments

Comments

@api-from-the-ion
Copy link
Contributor

If you look at the description of above mentioned methods in interface, you will see, that the array or the object should be skipped if the parser is inside the array's or object's context. Not at the beginning. These methods implemented correctly in the JsonStructureParser, but not in the JsonParserImpl. Here, one can't skip to the end of the array or object if one is already inside the context.

Found this during the test for this Yasson ticket 630. I'll create a PR with changes to correct this.
api-from-the-ion added a commit to api-from-the-ion/parsson that referenced this issue Nov 13, 2023
@api-from-the-ion
[eclipse-ee4j#112]Corrected skip methods behavior of JsonParserImpl; …
c1a42cb 
…created test for these methods

Signed-off-by: Anton Pinsky <[email protected]>
api-from-the-ion added a commit to api-from-the-ion/parsson that referenced this issue Nov 14, 2023
@api-from-the-ion
[eclipse-ee4j#112]Deduplicate the Context code in the JsonParserImpl
5c41302 
Signed-off-by: Anton Pinsky <[email protected]>
api-from-the-ion added a commit to api-from-the-ion/parsson that referenced this issue Nov 14, 2023
@api-from-the-ion
[eclipse-ee4j#112]Small POM plugin updates
872f0e1 
Signed-off-by: Anton Pinsky <[email protected]>
api-from-the-ion added a commit to api-from-the-ion/parsson that referenced this issue Nov 14, 2023
@api-from-the-ion
[eclipse-ee4j#112]Removed static imports; replaced tabs with spaces
b8b874b 
Signed-off-by: Anton Pinsky <[email protected]>
api-from-the-ion added a commit to api-from-the-ion/parsson that referenced this issue Nov 14, 2023
@api-from-the-ion
[eclipse-ee4j#112]Introduce Checkstyle plugin; immediately got 468 er…
6819ba3 
…rors

Signed-off-by: Anton Pinsky <[email protected]>
api-from-the-ion added a commit to api-from-the-ion/parsson that referenced this issue Nov 14, 2023
@api-from-the-ion
[eclipse-ee4j#112]build.sh to make a local build of GitHub actions
1b1933e 
Signed-off-by: Anton Pinsky <[email protected]>
lukasj pushed a commit that referenced this issue Feb 26, 2024
@api-from-the-ion
[#112]Corrected skip methods behavior of JsonParserImpl; (#113)
dfbe33a 
Signed-off-by: Anton Pinsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@api-from-the-ion