Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Siri support to start and stop the VPN. #3415

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

diegoreymendez
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1207603085593419/1208485618883329/f

Description

Adds Siri support to start and stop the VPN.

Testing:

IMPORTANT: clean your build before running this as shortcuts seem to be flakey at first.

  1. Run the app.
  2. Ask Siri to start the VPN
  3. Ask Siri to stop it

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

github-actions bot commented Dec 10, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 27aa4b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant