Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a VPN control widget for the control center and lock screen #3414

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Oct 6, 2024

Task/Issue URL: https://app.asana.com/0/1203108348835387/1208485618883319/f

Description

Adds a VPN control widget for the control center and lock screen.

Testing

  1. Go to the control center dashboard
  2. Add a widget
  3. Search for "VPN", and you should see our widget to toggle the VPN on/off. Add it.
  4. You can resize the widget in the dashboard before saving.
  5. Turn the VPN on/off, make sure it works.
  6. Go to the lock screen, press on the background for a few seconds.
  7. Customize your lock screen.
  8. Remove one of the two circle-widgets in the bottom of the lock screen, and add the VPN one.
  9. Make sure it works well.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Internal references:

Software Engineering Expectations
Technical Design Template

@diegoreymendez diegoreymendez self-assigned this Oct 6, 2024
@diegoreymendez diegoreymendez marked this pull request as draft October 6, 2024 15:43
Copy link

github-actions bot commented Dec 3, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 3acb595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant