Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scrolling all of the password management list mode screen #5377

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Dec 10, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1208758825735780/f

Description

This PR tweaks the layout params for the password recycler view so that the whole view content, already encapsulated in a NestedScrollView, is scrollable.

  • Before, you had to scroll on the list view directly, and then only the passwords list would scroll while the rest of the views above were fixed.
  • Now, the entire view (including the toggle) is scrollable

Steps to test this PR

  • Visit password management view when you have 0 passwords; verify it looks fine and unchanged from before
  • Add a single password; verify the password appears immediately below the horizontal divider
  • Add enough passwords that they appear down below the screen.
  • Verify that scrolling scrolls the whole content, and not just the password list itself
  • Verify you can scroll on the list, or scroll on the sync panel, or the text etc… and the whole page scrolls the same way

Screenshots

Current behavior

current

### New behavior
after

Copy link
Member Author

CDRussell commented Dec 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CDRussell CDRussell marked this pull request as ready for review December 10, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants