Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Android 15 (SDK 35) #5204

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Conversation

mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Oct 28, 2024

Task/Issue URL: https://app.asana.com/0/1207908166761516/1206705314358009/f

Description

Waiting on an update to Flipper for 16KB page sizes

Steps to test this PR

  • Smoke test app
  • Pay attention to TextViews/EditText, especially when changing languages as there's been some changes here in respect to establishing width and height

UI changes

N/A

Copy link
Contributor Author

mikescamell commented Oct 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

we can tackle this at a later date
SupportFactory -> SupportOpenHelperFactory
It's false by default and was only added as protection. Since SQLCipher has supported sqlite 3.26.0 since 4.0.1 (released 2018) this should no longer be a concern in my opinion: https://www.zetetic.net/blog/2018/12/18/sqlcipher-401-release/
"The List type in Java is mapped to the MutableList type in Kotlin. Because the List.removeFirst() and List.removeLast() APIs have been introduced in Android 15 (API level 35), the Kotlin compiler resolves function calls, for example list.removeFirst(), statically to the new List APIs instead of to the extension functions in kotlin-stdlib."

Robolectric supports 34 right now so easier that we just change these functions.
The function in this class was not used but we can rename it and use it as it uses the removeAt function which we need due to the collision with the stdlib.
@mikescamell mikescamell force-pushed the feature/mike/android-15 branch from ed1c9a8 to 52e4a50 Compare December 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant