[Reopen] Fix ANCM installer on ARM64 #59481
Open
+140
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
halter73
force-pushed
the
halter73/lextm-47290
branch
from
60673e6 to
fbf7f11
Compare
halter73
requested review from
BrennanConroy,
JamesNK and
mgravell
as code owners
|
@halter73 Thanks for reopening the discussion. The patches for #47290 have been out-of-date by now. I have improved and tested the required changes elsewhere, so I opened a new pull request #59483 to share those improvements. Compared to the original pull request, it also fixed the IIS Express ARM64 installer. I suggest that the reviewers focus on #59483 instead of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively reopening @lextm's PR (#47290) from over a year ago. I would have actually reopened that PR if GitHub let me, but it did not.
We have gotten more reports of how broken the ANCM ARM64 installer is when you enable x86 and x64 emulation. Enabling emulation with ANCM installed will cause all app pools to crash on startup, even those that aren't using ANCM. This is all well described in the issue @lextm filed at #47115, but we missed the severity of the impact until now.
@lextm, I found your blogpost describing your valiant attempt to get this merged the first time. I'm very sorry for the "The Not-So-Happy Ending". I'm hoping to correct it now. If you want to reopen the PR yourself, please feel welcome. I don't expect that though.
Otherwise, I know you've had a lot of experience since then helping people out with https://github.com/lextm/ancm-arm64. If there's anything you want us to change about this PR, please let us know. Thanks for all your hard work filing the issue, submitting a PR, and then helping people manually patch the installer.
Fixes #47115