Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-logins.md by using Google.Apis.Auth.AspNetCore3 package #33710

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

sharafabacery
Copy link

@sharafabacery sharafabacery commented Sep 25, 2024

using https://developers.google.com/identity/sign-in/web/sign-in old link lead me for wrong integration
for that I search for new links and found it
for that I Contribute to help others to try this approach
This is my fist Contribution in open source ,I hope I do great.

Fixes #33815


Internal previews

📄 File 🔗 Preview link
aspnetcore/security/authentication/social/google-logins.md aspnetcore/security/authentication/social/google-logins

using https://developers.google.com/identity/sign-in/web/sign-in
old link lead me for wrong integration for that I search  for new links and found  it for that I Contribute to help others to try this approach
This is my fist Contribution in open source ,I hope I do great.
@sharafabacery
Copy link
Author

@dotnet-policy-service agree

@Rick-Anderson Rick-Anderson marked this pull request as draft October 8, 2024 01:38
@sharafabacery sharafabacery marked this pull request as ready for review October 8, 2024 03:19
Copy link
Author

@sharafabacery sharafabacery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @sharafabacery! In addition to Rick's suggestions I have added a few minor ones.

Also, update the meta data for "ms.date: 3/3/2022" to the current the current date so readers will see that the content has been refreshed.

@sharafabacery
Copy link
Author

thanks both of you for review and help @Rick-Anderson @wadepickett

@wadepickett
Copy link
Contributor

@sharafabacery,
Is the intent to uplodaed the completed project at the following location before publishing the document update?:
https://github.com/dotnet/AspNetCore.Docs.Samples/tree/main/security/authorization/social + /GoogleAuthExample

@sharafabacery
Copy link
Author

@wadepickett this dotnet/AspNetCore.Docs.Samples#264 issue contain pull request of the code I create

@Rick-Anderson
Copy link
Contributor

I'm guessing we don't need a sample download.

@sharafabacery
Copy link
Author

sharafabacery commented Oct 24, 2024

I can remove mr @Rick-Anderson

@wadepickett wadepickett self-requested a review October 29, 2024 18:37
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes pending to completion and review of the specific changes Rick requested.

@sharafabacery
Copy link
Author

hello mr @Rick-Anderson is there any thing need to change?

@wadepickett
Copy link
Contributor

@Rick-Anderson, you also good with the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Google.Apis.Auth.AspNetCore3
3 participants