-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google-logins.md by using Google.Apis.Auth.AspNetCore3 package #33710
base: main
Are you sure you want to change the base?
Conversation
using https://developers.google.com/identity/sign-in/web/sign-in old link lead me for wrong integration for that I search for new links and found it for that I Contribute to help others to try this approach This is my fist Contribution in open source ,I hope I do great.
@dotnet-policy-service agree |
Co-authored-by: Rick Anderson <[email protected]>
Co-authored-by: Rick Anderson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Co-authored-by: Wade Pickett <[email protected]>
Co-authored-by: Wade Pickett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @sharafabacery! In addition to Rick's suggestions I have added a few minor ones.
Also, update the meta data for "ms.date: 3/3/2022" to the current the current date so readers will see that the content has been refreshed.
Co-authored-by: Wade Pickett <[email protected]>
Co-authored-by: Wade Pickett <[email protected]>
thanks both of you for review and help @Rick-Anderson @wadepickett |
@sharafabacery, |
@wadepickett this dotnet/AspNetCore.Docs.Samples#264 issue contain pull request of the code I create |
I'm guessing we don't need a sample download. |
I can remove mr @Rick-Anderson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve these changes pending to completion and review of the specific changes Rick requested.
hello mr @Rick-Anderson is there any thing need to change? |
@Rick-Anderson, you also good with the changes? |
using https://developers.google.com/identity/sign-in/web/sign-in old link lead me for wrong integration
for that I search for new links and found it
for that I Contribute to help others to try this approach
This is my fist Contribution in open source ,I hope I do great.
Fixes #33815
Internal previews