Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing MapRedeemerKeyToRedeemerVal as default Redeemer #366

Open
solidsnakedev opened this issue Nov 22, 2024 · 7 comments · May be fixed by #368
Open

Missing MapRedeemerKeyToRedeemerVal as default Redeemer #366

solidsnakedev opened this issue Nov 22, 2024 · 7 comments · May be fixed by #368

Comments

@solidsnakedev
Copy link

solidsnakedev commented Nov 22, 2024

Currently, the default transaction builder relies on the LegacyRedeemer, but the new hard fork enforces the redeemer to be a map.

https://github.com/IntersectMBO/cardano-ledger/blob/397bf8fa1ebf94c3bc962a1a14e73f0c30453b09/eras/conway/impl/cddl-files/conway.cddl#L343-L345

@rooooooooob
Copy link
Contributor

@solidsnakedev do/will you have a fix yourselves or should I work on one?

@solidsnakedev
Copy link
Author

I'd be great if you can, happy to help doing some preview testing on my end

rooooooooob added a commit that referenced this issue Nov 27, 2024
The upcoming hardfork will switch to only the new map redeemer format.
This PR makes that the new default within all the builders.

Fixes #366
@rooooooooob rooooooooob linked a pull request Nov 27, 2024 that will close this issue
@rooooooooob
Copy link
Contributor

@solidsnakedev let me know if #368 works for you

@solidsnakedev
Copy link
Author

that was pretty fast, thank you! will do some tests soon

@rooooooooob
Copy link
Contributor

@solidsnakedev which network exactly has been upgraded? is it the regular preview that's been changed? or another preview network that has been spun up?

@solidsnakedev
Copy link
Author

Both preprod and preview already forked to Chang 2.
AFAIK the old transaction format is still valid, but to be honest, I'm not sure when exactly the new format is going to be mandatory (CDDL is the only place where it says it is going to be mandatory in the new era).
The only thing I know for sure is that the recommendation is to upgrade all the toolings as soon as possible.

@rooooooooob
Copy link
Contributor

So CML was never failing on the new networks? The thing with upgrading is that if it's in the next hardfork there are likely a bunch of other CDDL changes anyway so it would have been easier for us to just wait and make the changes then for us since we'd be doing CDDL-regeneration anyway. I guess for the redeemer case the builder part is now a bit easier to migrate over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants