-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing MapRedeemerKeyToRedeemerVal as default Redeemer #366
Comments
@solidsnakedev do/will you have a fix yourselves or should I work on one? |
I'd be great if you can, happy to help doing some preview testing on my end |
The upcoming hardfork will switch to only the new map redeemer format. This PR makes that the new default within all the builders. Fixes #366
@solidsnakedev let me know if #368 works for you |
that was pretty fast, thank you! will do some tests soon |
@solidsnakedev which network exactly has been upgraded? is it the regular preview that's been changed? or another preview network that has been spun up? |
Both preprod and preview already forked to Chang 2. |
So CML was never failing on the new networks? The thing with upgrading is that if it's in the next hardfork there are likely a bunch of other CDDL changes anyway so it would have been easier for us to just wait and make the changes then for us since we'd be doing CDDL-regeneration anyway. I guess for the redeemer case the builder part is now a bit easier to migrate over. |
Currently, the default transaction builder relies on the LegacyRedeemer, but the new hard fork enforces the redeemer to be a map.
https://github.com/IntersectMBO/cardano-ledger/blob/397bf8fa1ebf94c3bc962a1a14e73f0c30453b09/eras/conway/impl/cddl-files/conway.cddl#L343-L345
The text was updated successfully, but these errors were encountered: