[#1466] Filter intersection of tags #1467
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Ekrekr
requested changes
Mar 28, 2024
| @@ -10,6 +10,7 @@ option go_package = "github.com/dataform-co/dataform/protos/dataform"; | |||
| message RunConfig { | |||
| repeated string actions = 1; | |||
| repeated string tags = 5; | |||
| bool include_all_tags = 10; | |||
There was a problem hiding this comment.
"include all" is ambiguous in semantic meaning - IMO something like filterTagsAsIntersection would be better as it's more explicit.
Comment on lines
+412
to
+417
| expect(actionNames).includes("schema.op_e"); | ||
| expect(actionNames).includes("schema.tab_a"); | ||
| expect(actionNames).not.includes("schema.op_a"); | ||
| expect(actionNames).not.includes("schema.op_b"); | ||
| expect(actionNames).not.includes("schema.op_c"); | ||
| expect(actionNames).not.includes("schema.op_d"); |
There was a problem hiding this comment.
This would be better as expect(actionNames).deep.equals(["schema.op_e", "schema.op_a"]);
| allActions | ||
| .filter(action => action.tags.some(tag => runConfig.tags.includes(tag))) | ||
| .forEach(action => includedActionNames.add(targetAsReadableString(action.target))); | ||
| // Keep actions wich include every tags in --tag option |
There was a problem hiding this comment.
Suggested change
| // Keep actions wich include every tags in --tag option | |
| // Select actions which match the intersection of the set of tags. |
| .filter(action => runConfig.tags.every(tag => action.tags.includes(tag))) | ||
| .forEach(action => includedActionNames.add(targetAsReadableString(action.target))); | ||
| } | ||
| // Keep actions with include at least one tag in --tag option |
There was a problem hiding this comment.
Suggested change
| // Keep actions with include at least one tag in --tag option | |
| // Select actions which match the union of the set of tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added a new flag
--include-all-tagsthat works with--tagsoptions to get the behavior requested in #1466Default flag value is set to false to keep existing behavior unchanged