Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test is not working for external contributors #1755

Open
moker-spaghetti opened this issue Jun 15, 2024 · 2 comments
Open

Integration test is not working for external contributors #1755

moker-spaghetti opened this issue Jun 15, 2024 · 2 comments

Comments

@moker-spaghetti
Copy link
Contributor

Found in #1746 #1751 #1754 (Addressing the issue in #1754)
Originates in #1729 ?

External contirbutors cannot run the integration test (scripts/run_tests) since the decryption phase of test_credentials/bigquery.json.enc fails.

@Ekrekr
Copy link
Contributor

Ekrekr commented Aug 16, 2024

Some more context: the GCP project that the integration tests run in has an org policy which prevents non-Googlers from accessing it - and there's no current workaround.

Long term we may test against a BQ emulator instead, so that the GCP project connection isn't required for testing.

For now just disabling the integration tests when you run the test script is the only option, and having the PR approver run the tests before merging, is what has to be done.

@bmagyarkuti
Copy link
Contributor

A suggestion: if we just extracted the project name to an envvar, and set up the test environment to prefer application default credentials over the encrypted file, external contributors would be able to set up their own GCP project and run tests there, without having to make any modifications to the code. The project itself is trivial to set up, and luckily the tests don't depend on any assets there.

This would streamline my own workflow, which currently involves cherry-picking commits that change the GCP project and overwrite the encrypted credentials from my own local commit history.

It'd be great if there existed an officially supported BigQuery emulator, but I've yet to find one that is full-featured and is able to reliable replicate BQ's full feature set (I just mean its interface, I'm not expecting the emulator to replicate its performance.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants