Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: Android 12, BLUETOOTH_CONNECT & getBondedDevices() #788

Closed
dariuszseweryn opened this issue May 28, 2022 · 4 comments · Fixed by #804
Closed

Investigate: Android 12, BLUETOOTH_CONNECT & getBondedDevices() #788

dariuszseweryn opened this issue May 28, 2022 · 4 comments · Fixed by #804

Comments

@dariuszseweryn
Copy link
Owner

As hinted in #768 — on Android 12 there apparently is a need to have BLUETOOTH_CONNECT permission when calling RxBleClient.getBondedDevices().

If you, the reader, have an Android 12 device and you're willing to help and check — please do.

If that is the case update Javadocs.

@DaBs
Copy link
Contributor

DaBs commented Jun 15, 2022

Hi Darius, I made the original PR that I can see you've merged now, and that seems to be entirely correct based on what we can see of usage.

How should we go about it from here?

@dariuszseweryn
Copy link
Owner Author

@DaBs I am thinking whether there should be a separate library exception or is the system one just fine, especially that this API is synchronous

@DaBs
Copy link
Contributor

DaBs commented Jul 8, 2022

@dariuszseweryn I think system error should be fine honestly - getting the error is clear and concise. I also don't remember seeing us map other instances of permission errors, but maybe I'm wrong?

@dariuszseweryn
Copy link
Owner Author

I have added that info to Javadoc and left the feature as it is. Thanks for the opinion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants