[dagster-embedded-elt] Expose dlt and sling extras #26497
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-b7wh6wgpd-elementl.vercel.app Direct link to changed pages: |
deepyaman
force-pushed
the
deepyaman/build/embedded-elt-extras
branch
from
ae1d5f3 to
586f9a8
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-63xuyaycb-elementl.vercel.app Direct link to changed pages: |
|
@cmpadden @PedramNavid do either of you recall why we didn't do it this way to begin with? I remember there was some discussion about having embedded-elt be its own package vs. having dagster-sling and dagster-dlt, wondering if there's some context missing there |
|
Can’t think of any reason why we wouldn’t do this. Will this be a breaking change? |
OwenKephart
requested changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As a user, I don't unnecessarily want to install Sling if I'm only using dlt and vice versa.
How I Tested These Changes
Changelog