Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete extra_source_assets param from assets_from_modules #26494

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpeng817
Copy link
Contributor

Summary & Motivation

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor Author

dpeng817 commented Dec 13, 2024

Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see -- sadly this is a public API so we can't actually delete this arg, right?

we could at least make it a hidden param

@dpeng817
Copy link
Contributor Author

@OwenKephart i don't think this is a public api actually. Searched for reference at top level and couldn't find. Was added pre 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants