Fix extra slice growth in rebuildOrderHeap #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebuildOrderHeap was allocing a slice with a len of the max required size, then
appending unbound vars to it. This resulted in a slice with nbVars entries of
'0' to start with, followed by the actual unbound vars. Adding those unbound
vars would cause slice growth.
Ultimately, all but the last leading
0
value would be ignored by the queue,and maybe that shouldn't have been there, as that var might already have been
bound?
Replace the slice alloc
len
form with thecap
form, so there's no leading'0's, and append doesn't cause slice growth.