Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expPanelFun should be a fullpath #291

Open
k1o0 opened this issue Mar 12, 2020 · 0 comments
Open

expPanelFun should be a fullpath #291

k1o0 opened this issue Mar 12, 2020 · 0 comments
Labels

Comments

@k1o0
Copy link
Contributor

k1o0 commented Mar 12, 2020

Describe the bug
Currently expPanelFun (added by inferParameters) is just the name. If there is a panel of the same name in the path, that one is loaded, instead of the one in the folder of your expDef. Also fileFunction should be used in case the panel isn't on the path:

Rigbox/+eui/ExpPanel.m

Lines 138 to 141 in cd888f0

% FIXME This should be done with fileFunction and this use of which
% may not work on newer versions of MATLAB
if isempty(which(params.Struct.expPanelFun)); addpath(fileparts(params.Struct.defFunction)); end
p = feval(params.Struct.expPanelFun, parent, ref, params, logEntry);

Expected behavior
Should be a full path to ensure the correct panel class is instantiated.

@k1o0 k1o0 added the bug label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant