The histogram function is missing a parameter determine_min_max

[haesleinhuepf]

... which it had in the _prototpye. This is what it does:

https://github.com/clEsperanto/pyclesperanto_prototype/blob/8bd12efd32d2bcdbfc859bcfec85c7a567e17b06/pyclesperanto_prototype/_tier3/_histogram.py#L93-L95

I'm ok with not implementing this, but it must go in the transition guide document otherwise.

[StRigaud]

did not see the use of the parameter, ok to put it in the transition guide

[haesleinhuepf]

did not see the use of the parameter

It's user friendly, because it allows you to determine a histogram without the need to determine min and max before. It's the default in tools like ImageJ ;-)

[StRigaud]

It's user friendly, because it allows you to determine a histogram without the need to determine min and max before. It's the default in tools like ImageJ ;-)

Yeah, but if you do not provide the min or max, the histogram recompile them already. I find this redondant with default value (on the python side, they are marked as Optionnal) , and unclear for the user actually as is allows to overwrite parameter provided by the user.

It can make sense in ImageJ though as it has a GUI, this is not the case for pyclesperanto.

[haesleinhuepf]

, the histogram recompile them already.

❤️