Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morphological operator #386

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Morphological operator #386

wants to merge 7 commits into from

Conversation

StRigaud
Copy link
Member

Closes #385

reorganization of the dilate, erode, opening, closing operations as followed:

binary filter with pre-encoded structuring element (box and sphere) :

  • binary_dilate, binary_erode -> encapsulate dilate_box, erode_box
  • binary_opening, binary_closing -> reuse binary_dilate, binary_erode
  • legacy with prototype: dilate_box, erode_box

grayscale filter with pre-encoded structuring element (box only) :

  • grayscale_dilate, grayscale_erode -> encapsulate alias for minimum and maximum filter
  • grayscale_opening, grayscale_closing -> reuse grayscale_dilate, grayscale_erode
  • legacy with prototype: minimum_box, maximum_box, opening_box, closing_box

grayscale (compatible binary) with custom structuring element :

  • erosion and dilation (take a custom strel parameter)
  • opening and closing -> reusing erosion and dilation (take a custom strel parameter)

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 38.70968% with 133 lines in your changes missing coverage. Please review.

Project coverage is 46.11%. Comparing base (60a2e87) to head (58db07a).

Files with missing lines Patch % Lines
clic/src/tier1/dilation.cpp 33.33% 12 Missing and 6 partials ⚠️
clic/src/tier1/erosion.cpp 33.33% 12 Missing and 6 partials ⚠️
clic/src/tier2/closing.cpp 18.75% 11 Missing and 2 partials ⚠️
clic/src/tier2/opening.cpp 18.75% 11 Missing and 2 partials ⚠️
clic/src/tier1/gradients.cpp 62.50% 0 Missing and 9 partials ⚠️
clic/src/tier1/set_ramp.cpp 57.14% 0 Missing and 9 partials ⚠️
clic/src/tier1/sum_projection.cpp 62.50% 0 Missing and 9 partials ⚠️
clic/src/tier1/maximum_filter.cpp 22.22% 5 Missing and 2 partials ⚠️
clic/src/tier1/minimum_filter.cpp 22.22% 5 Missing and 2 partials ⚠️
clic/src/tier1/laplace_filter.cpp 33.33% 2 Missing and 2 partials ⚠️
... and 8 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   47.67%   46.11%   -1.57%     
==========================================
  Files         243      211      -32     
  Lines        4008     3871     -137     
  Branches     1835     1784      -51     
==========================================
- Hits         1911     1785     -126     
- Misses        660      720      +60     
+ Partials     1437     1366      -71

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

morphologie operator clean up
2 participants
@StRigaud @codecov-commenter