Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consistency amont camel case vs snake case #204

Open
xibz opened this issue Apr 15, 2024 · 1 comment · May be fixed by #242
Open

Ensure consistency amont camel case vs snake case #204

xibz opened this issue Apr 15, 2024 · 1 comment · May be fixed by #242
Assignees
@xibz
Labels
breaking change Indicates when a PR or issue will have breaking changes
Milestone
v0.5

Comments

@xibz
Copy link
Contributor

xibz commented Apr 15, 2024 •
edited
Loading

The links spec introduced snake casing, instead of camel casing. So we should ensure that these get moved over to camel casing.

These 3 are what I found:

  1. link_type
  2. context_id
  3. chain_id

We should also add a linter to ensure snake casing isn't added in any future proposals.
@xibz xibz added the breaking change Indicates when a PR or issue will have breaking changes label Apr 15, 2024
@xibz xibz self-assigned this Apr 15, 2024
@xibz xibz mentioned this issue Apr 16, 2024
Merged
@e-backmark-ericsson e-backmark-ericsson added this to the v0.5 milestone Apr 22, 2024
@davidB
Copy link
Contributor

davidB commented Oct 5, 2024

@xibz, If ok, you can close this issue?

@xibz xibz linked a pull request Nov 8, 2024 that will close this issue
Open
@xibz xibz moved this from Todo to Review in CDEvents Releases Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xibz xibz

Labels
breaking change Indicates when a PR or issue will have breaking changes
Projects
CDEvents Releases
Status: Review
Milestone
v0.5
Development

Successfully merging a pull request may close this issue.

Fix consistency with casing xibz/spec
3 participants
@davidB @xibz @e-backmark-ericsson