-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the source fetchers #1473
Comments
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now
pkg/registry/fetch.go
is in a bit of a weird place - it abstracts away the actual fetching of the image to an interface and doesn't interact with the other components of the same package.I ran into this when I wanted to import a CNB-related constant into the registry fetcher, it fell into an import cycle of
pkg/registry
->pkg/cnb
->pkg/dockercreds
->pkg/registry
. Maybe I could've created apkg/cnb/consts
package for all the constants, but I feel thatregistry.Fetcher
has fundamentally different uses thanregistry.Client
,registry.KeychainFactory
, andregistry.Resolver
.The text was updated successfully, but these errors were encountered: