Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide some info to users if NiftyReg segfaults #120

Open
adamltyson opened this issue Jun 19, 2023 · 3 comments
Open

Provide some info to users if NiftyReg segfaults #120

adamltyson opened this issue Jun 19, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@adamltyson
Copy link
Member

When NiftyReg segfaults, it is nearly always because of an issue relating to incorrect voxel sizes. It would be great to catch this and print something like :
Registration has failed. Please ensure that the voxel sizes you have entered are correct. Please see .... for more details

In the mean time, this can be documented .

@adamltyson
Copy link
Member Author

Now documented at https://brainglobe.info/documentation/brainreg/troubleshooting.html

@adamltyson
Copy link
Member Author

We could also try to warn users preemptively with something like:

  • Load data
  • calculate physical dimensions of the input data
  • warn user if any dimension is vastly different between the atlas and the data (indicative of wrong input parameters).

The complication is that different tissue processing techniques can shrink/swell tissue quite a but, so we would have to think carefully about what "vastly" different was. I guess if it was just a warning, then the factor could be low (say 1.5x?).

cc @alessandrofelder

@alessandrofelder
Copy link
Member

Yea, agree with your reasoning that a warning would make sense, and allow for a lower factor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants