Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pm-15123] Add delete permissions for CS and Billing roles. #5145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JimmyVo16
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-15123

๐Ÿ“” Objective

Add delete permissions for CS and Billing roles.

๐Ÿ“ธ Screenshots

CS

image

Billing

image

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@JimmyVo16 JimmyVo16 self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.89%. Comparing base (94761a8) to head (a934404).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/Admin/Utilities/RolePermissionMapping.cs 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5145      +/-   ##
==========================================
- Coverage   42.92%   42.89%   -0.04%     
==========================================
  Files        1433     1435       +2     
  Lines       65672    65733      +61     
  Branches     6022     6032      +10     
==========================================
+ Hits        28191    28193       +2     
- Misses      36215    36274      +59     
  Partials     1266     1266              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ b2799073-e3bf-4370-8c89-d74cdebfa93d

Fixed Issues

Severity Issue Source File / Package
LOW Unsafe_Use_Of_Target_blank /src/Core/MailTemplates/Handlebars/OrganizationDomainUnclaimed.html.hbs: 20

@JimmyVo16 JimmyVo16 requested review from a team and r-tome December 12, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants