Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply linting #5141

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Apply linting #5141

wants to merge 2 commits into from

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Dec 11, 2024

🎟️ Tracking

Internal lint testing.

📔 Objective

Applies the MegaLinter's .NET formatters:

npx mega-linter-runner --containername "megalinter-incremental" --flavor formatters --remove-container --fix --env 'APPLY_FIXES=all'

across the entire repository.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@withinfocus
Copy link
Contributor Author

Notes:

  • Code reference collection fails because the PR is too large.
  • Build issues are created.
  • Testing fails given some strange changes such as:

error CS0176: Member 'Organization.GatewayIdField()' cannot be accessed with an instance reference; qualify it with a type name instead

which is aligned with the build issues.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Logo
Checkmarx One – Scan Summary & Details52e3c878-f503-4387-9171-01a5c80cc3bf

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 45 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 470 Attack Vector
MEDIUM CSRF /src/Api/Auth/Controllers/TwoFactorController.cs: 111 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 449 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 448 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 372 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 371 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 515 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 198 Attack Vector
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 1057 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 659 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 668 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 244 Attack Vector
MEDIUM CSRF /src/Identity/Controllers/SsoController.cs: 110 Attack Vector
MEDIUM CSRF /src/Billing/Controllers/FreshsalesController.cs: 51 Attack Vector
MEDIUM CSRF /src/Billing/Controllers/FreshdeskController.cs: 45 Attack Vector
MEDIUM CSRF /src/Billing/Controllers/BitPayController.cs: 52 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1204 Attack Vector
MEDIUM CSRF /src/Api/Tools/Controllers/ImportCiphersController.cs: 70 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ServiceAccountsController.cs: 187 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ServiceAccountsController.cs: 123 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsTrashController.cs: 33 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsManagerPortingController.cs: 77 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 273 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 105 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 79 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 79 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 52 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/CountsController.cs: 38 Attack Vector
MEDIUM CSRF /src/Api/SecretsManager/Controllers/AccessPoliciesController.cs: 284 Attack Vector
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationSponsorshipsController.cs: 42 Attack Vector
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs: 52 Attack Vector
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 78 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 778 Attack Vector
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 234 Attack Vector
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 184 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 736 Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 106 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 287 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 286 Attack Vector
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 304 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 779 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 778 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 736 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 233 Attack Vector
MEDIUM CSRF /src/Api/Public/Controllers/CollectionsController.cs: 92 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 702 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 702 Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 120 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 218 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 231 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 177 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 154 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 134 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 80 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProvidersController.cs: 80 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProvidersController.cs: 59 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 81 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 49 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 492 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 468 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 399 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 333 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 561 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 485 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 406 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 233 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationDomainController.cs: 84 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 210 Attack Vector
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 231 Attack Vector
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 182 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/EventsController.cs: 104 Attack Vector
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/ProvidersController.cs: 476 Attack Vector
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/ProvidersController.cs: 449 Attack Vector
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/ProvidersController.cs: 403 Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 88 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 703 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 737 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 737 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 668 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 703 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1120 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 213 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 213 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 649 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 650 Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 170 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1161 Attack Vector
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 279 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 779 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 180 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/UserFeatures/WebAuthnLogin/Implementations/GetWebAuthnLoginCredentialCreateOptionsCommand.cs: 54 Attack Vector
MEDIUM Privacy_Violation /bitwarden_license/src/Sso/Utilities/DynamicAuthenticationSchemeProvider.cs: 329 Attack Vector
MEDIUM Privacy_Violation /bitwarden_license/src/Sso/Utilities/DynamicAuthenticationSchemeProvider.cs: 327 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 245 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 254 Attack Vector
MEDIUM Privacy_Violation /src/Api/Auth/Models/Request/Accounts/SetPasswordRequestModel.cs: 32 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 1518 Attack Vector
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 192 Attack Vector
MEDIUM Privacy_Violation /src/Api/AdminConsole/Controllers/OrganizationAuthRequestsController.cs: 74 Attack Vector
MEDIUM SSRF /src/Billing/Controllers/FreshdeskController.cs: 47 Attack Vector
MEDIUM SSRF /src/Billing/Controllers/FreshdeskController.cs: 47 Attack Vector
LOW Heap_Inspection /src/Api/Vault/Models/CipherPasswordHistoryModel.cs: 29 Attack Vector
LOW Heap_Inspection /src/Core/Vault/Services/Implementations/LocalAttachmentStorageService.cs: 40 Attack Vector
LOW Heap_Inspection /src/Api/Vault/Controllers/CiphersController.cs: 1481 Attack Vector
LOW Heap_Inspection /util/Setup/EnvironmentFileBuilder.cs: 79 Attack Vector
LOW Heap_Inspection /util/Setup/CertBuilder.cs: 126 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 82 Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 175

More results are available on AST platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant