Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13999] show estimated tax for taxable countries #5110

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13999

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner December 4, 2024 14:37
@jonashendrickx jonashendrickx changed the title Pm 13999 show estimated tax for taxable countries [PM-13999] show estimated tax for taxable countries Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Logo
Checkmarx One – Scan Summary & Details59218e55-3579-4e5c-9a87-dfb79bf66b3f

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Billing/Controllers/InvoicesController.cs: 16 Attack Vector
MEDIUM CSRF /src/Api/Billing/Controllers/AccountsBillingController.cs: 83 Attack Vector
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 66 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 166 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 166 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 166 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 110 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 714 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 639 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 639 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 714 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 110 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 110 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 714 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 639 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 829 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 829 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 306 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 110 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 829 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 306 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 110 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 20 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 306 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 110 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 17 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 20 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 17 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 20 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 17 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/AccountsBillingController.cs: 83 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/AccountsBillingController.cs: 83 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/AccountsBillingController.cs: 83 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 185 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 170 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 166 Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/DomainClaimedByOrganization.html.hbs: 5 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 68
MEDIUM CSRF /src/Api/Controllers/LicensesController.cs: 44
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 106
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 238
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 65
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 46
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 372
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 89
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 66.64239% with 458 lines in your changes missing coverage. Please review.

Project coverage is 43.36%. Comparing base (2d891b3) to head (0522078).

Files with missing lines Patch % Lines
...e/Services/Implementations/StripePaymentService.cs 2.61% 297 Missing and 1 partial ⚠️
...ling/Services/Implementations/SubscriberService.cs 30.76% 24 Missing and 3 partials ⚠️
...ices/Implementations/OrganizationBillingService.cs 7.40% 25 Missing ⚠️
...vices/Implementations/PremiumUserBillingService.cs 7.40% 25 Missing ⚠️
src/Api/Billing/Controllers/InvoicesController.cs 0.00% 16 Missing ⚠️
src/Core/Billing/Extensions/CurrencyExtensions.cs 0.00% 9 Missing ⚠️
...izations/PreviewOrganizationInvoiceRequestModel.cs 0.00% 9 Missing ⚠️
...i/Billing/Controllers/AccountsBillingController.cs 0.00% 8 Missing ⚠️
src/Api/Auth/Controllers/AccountsController.cs 0.00% 6 Missing ⚠️
src/Core/Services/Implementations/StripeAdapter.cs 14.28% 6 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5110      +/-   ##
==========================================
+ Coverage   42.86%   43.36%   +0.49%     
==========================================
  Files        1440     1449       +9     
  Lines       65825    66947    +1122     
  Branches     6035     6068      +33     
==========================================
+ Hits        28214    29029     +815     
- Misses      36345    36651     +306     
- Partials     1266     1267       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…taxable-countries' into PM-13999-Show-estimated-tax-for-taxable-countries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants