Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14894] Drop Tax Rates Tables #5107

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.86%. Comparing base (94fdfa4) to head (a2d9ebd).

Files with missing lines Patch % Lines
src/Admin/Views/Shared/_Layout.cshtml 0.00% 1 Missing ⚠️
...ling/Services/Implementations/SubscriberService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5107      +/-   ##
==========================================
+ Coverage   43.65%   43.86%   +0.20%     
==========================================
  Files        1433     1424       -9     
  Lines       66029    65690     -339     
  Branches     5969     5929      -40     
==========================================
- Hits        28827    28812      -15     
+ Misses      35958    35635     -323     
+ Partials     1244     1243       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Logo
Checkmarx One – Scan Summary & Details66e1ba47-de4a-47bd-97e9-36e4c39f5279

No New Or Fixed Issues Found

…-Tables' into PM-14894-Drop-Sales-Tax-Database-Tables
…-Tables' into PM-14894-Drop-Sales-Tax-Database-Tables
…-Tables' into PM-14894-Drop-Sales-Tax-Database-Tables
@jonashendrickx jonashendrickx changed the title [PM-14894] [PM-14894] Drop Tax Rates Tables Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant