[PM-15392] Decode Foreign Encodings at User Creation #5082
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the correct file. Co-authored by Luris <[email protected]>
|
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
Patrick-Pimentel-Bitwarden
previously approved these changes
Dec 2, 2024
1 task
Patrick-Pimentel-Bitwarden
dismissed
their stale review
I didn't follow the auth team's procedure and give the team a chance to review the pr together. We will review it soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
#4845 (comment)
📔 Objective
Solve the issue of coded foreign characters getting into emails. Was: 'Windmüller' Now: 'Windmüller'
Notes:
Our test are probably in the wrong file. We tried to find the best fitting file we could.
We tried to find the place where the string gets coded to 'ü' and other foreign characters, but we ended up assuming that it was coming from the api call into the controller. Our solution does not work if that is not the case.
Co-authors
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes