Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url not shown for snippet annotation #3495

Open
ccaneke opened this issue Sep 10, 2024 · 1 comment
Open

Url not shown for snippet annotation #3495

ccaneke opened this issue Sep 10, 2024 · 1 comment
Labels
bug good-first-issue Marks a good issue for first-time contributors.

Comments

@ccaneke
Copy link

ccaneke commented Sep 10, 2024

Describe the bug
In ~/.local/share/nyxt/annotations.lisp the annotation has a url but when I use the show-annotations command it does not have a url.

Precise recipe to reproduce the issue

  • Highlight text on webpage
  • annotate-highlighted text, add text and tags
  • show-annotations
  • Compare added annotation to the same one in ~/.local/share/nyxt/annotations.lisp

Screenshot from 2024-09-10 12-52-06

For website-specific issues:
Can you reproduce this issue with Epiphany / GNOME Web (https://wiki.gnome.org/Apps/Web)?
N/A

Information

  • OS name+version: Fedora Linux 39 (Workstation Edition)
  • Graphics card and driver: Intel® UHD Graphics 620 (KBL GT2), Quadro P500
  • Desktop environment / Window manager name+version: GNOME Shell 45.6
  • Installation method (Flatpak, Guix, package manager, build from source): build from source
  • Output of nyxt --system-information:
$ ./nyxt --system-information
Nyxt version: 4
Renderer: GI-GTK
Operating system kernel: Linux 6.8.9-200.fc39.x86_64
Lisp implementation: SBCL 2.3.6-2.fc39 (Dynamic space size: 3221225472)
Features: (:NYXT-GI-GTK :NYXT-GTK :NYXT-GI-GTK :NYXT-GTK :WEBKIT2 :WEBKIT-2.44.1
 :WEBKIT-2.44 :WEBKIT-2 :WEBKIT2-CORS-ALLOWLIST :WEBKIT2-PASTE-PLAINTEXT
 :WEBKIT2-TRACKING :WEBKIT2-MUTE :WEBKIT2-EMOJI :WEBKIT2-MEDIA
 :WEBKIT2-SANDBOXING :GTK-3-22 :GTK-3-20 :GTK-3-18 :GTK-3-16 :GTK-3-14
 :GTK-3-12 :GTK-3-10 :GTK-3-8 :GTK-3-6 :GTK-3-4 :GTK :GDK-3-22 :GDK-3-20
 :GDK-3-18 :GDK-3-16 :GDK-3-14 :GDK-3-12 :GDK-3-10 :GDK-3-8 :GDK-3-6 :GDK-3-4
 :CAIRO-1-10 :CAIRO-1-12 :GDK-PIXBUF :GLIB-2-30 :GLIB-2-32 :GLIB-2-34
 :GLIB-2-36 :GLIB-2-38 :GLIB-2-40 :GLIB-2-42 :GLIB-2-44 :GLIB-2-46 :GLIB-2-48
 :GLIB-2-50 :GLIB-2-52 :GLIB-2-54 :GLIB-2-56 :GLIB-2-58 :GLIB :NYXT-4
 :CLIPBOARD-CONTENT-METHOD :SWANK :SLYNK :PLUMP-UTF-32 :PARENSCRIPT :NSYMBOLS
 :FSET-EXT-STRINGS :SBCL+SAFE-STANDARD-READTABLE :NAMED-READTABLES :GLOBAL-VARS
 :LPARALLEL :21BIT-CHARS :CUSTOM-HASH-TABLE-NATIVE :CLOSER-MOP
 :CL-PPCRE-UNICODE :CL-UNICODE :CL-JSON-DOUBLE-FLOAT-IS-SUBSUMED
 :CL-JSON-SINGLE-FLOAT-IS-SUBSUMED :CHUNGA :FLEXI-STREAMS :CL-PPCRE
 :BORDEAUX-THREADS :LPARALLEL.WITH-CLTL2 :LPARALLEL.WITH-CAS
 :LPARALLEL.WITH-STEALING-SCHEDULER :SPLIT-SEQUENCE
 CFFI-FEATURES:FLAT-NAMESPACE CFFI-FEATURES:X86-64 CFFI-FEATURES:UNIX :CFFI
 CFFI-SYS::FLAT-NAMESPACE ALEXANDRIA::SEQUENCE-EMPTYP :FAST-IO-SV :FAST-IO
 :CL-JSON-CLOS :CL-JSON :SBCL-USES-SB-ROTATE-BYTE CHIPZ-SYSTEM:GRAY-STREAMS
 :THREAD-SUPPORT :ASDF3.3 :ASDF3.2 :ASDF3.1 :ASDF3 :ASDF2 :ASDF :OS-UNIX
 :NON-BASE-CHARS-EXIST-P :ASDF-UNICODE :ARENA-ALLOCATOR :X86-64 :GENCGC :64-BIT
 :ANSI-CL :COMMON-LISP :ELF :IEEE-FLOATING-POINT :LINUX :LITTLE-ENDIAN
 :PACKAGE-LOCAL-NICKNAMES :SB-CORE-COMPRESSION :SB-LDB :SB-PACKAGE-LOCKS
 :SB-THREAD :SB-UNICODE :SBCL :UNIX)

ASDF version: 3.3.1
ASDF registries: (NYXT-SOURCE-REGISTRY ENVIRONMENT-SOURCE-REGISTRY USER-SOURCE-REGISTRY
                      USER-SOURCE-REGISTRY-DIRECTORY
                      DEFAULT-USER-SOURCE-REGISTRY SYSTEM-SOURCE-REGISTRY
                      SYSTEM-SOURCE-REGISTRY-DIRECTORY
                      DEFAULT-SYSTEM-SOURCE-REGISTRY)
Critical dependencies: (/home/user/common-lisp/nyxt/_build/cl-cffi-gtk/gtk/cl-cffi-gtk.asd
 /home/user/common-lisp/nyxt/_build/cl-gobject-introspection/cl-gobject-introspection.asd
 /home/user/common-lisp/nyxt/_build/cl-webkit/webkit2/cl-webkit2.asd)

Output when nyxt is run from command line
Not relevant

@aadcg aadcg added bug good-first-issue Marks a good issue for first-time contributors. labels Sep 16, 2024
@aadcg
Copy link
Member

aadcg commented Sep 16, 2024

@ccaneke I can reproduce, thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good-first-issue Marks a good issue for first-time contributors.
Development

No branches or pull requests

2 participants