You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Moltres supports precursor drift with uniform, function-based, or Navier-Stokes coupled velocities.
The current implementation of outlet postprocessors and inlet boundary conditions in PrecursorAction.C with function-based velocities and precursor looping:
does not impose an outlet postprocessor for calculating the precursor concentration at the outlet; and
imposes the wrong type of inlet boundary condition without any velocity values provided.
These errors lead to:
MooseError stating that Reporter name "Outlet_Average_pre1_/value" with type "double" is not declared.; and
homogeneous Dirichlet boundary conditions being imposed on the inlet.
How to reproduce
Issue 1:
Replace the lines 26-28 in $MOLTRES/tests/pre/sub.i:
Add the following code block anywhere outside other input sections:
[Functions]
[./vel_func]
type = ParsedFunction
value = ${flow_velocity}
[]
[]
The velocity function imposes the same constant velocity value as the original input file, but the pre_loop.i test fails due to the erroneous function-based velocity boundary conditions imposed by PrecursorAction.C.
Issue 2:
In addition to the code changes to reproduce Issue 1, replace line 401 in PrecursorAction.C:
if (getParam<bool>("constant_velocity_values"))
with:
if (getParam<bool>("constant_velocity_values") || !isParamValid("uvel"))
This step fixes Issue 1 but introduces Issue 2.
How to fix
Fix the outlet postprocessor implementation logic in PrecursorAction.C as suggested above.
Create an inflow boundary condition, similar to PostprocessorInflowBC, for function-based velocities and fix the inlet boundary condition implementation logic in PrecursorAction.C.
Create a test for precursor looping with function-based velocities.
The text was updated successfully, but these errors were encountered:
smpark7
changed the title
Fix function-based InflowBC and OutflowBC in PrecursorAction
Fix function-based InflowBC and Outflow postprocessor in PrecursorAction
May 8, 2024
Issue
Moltres supports precursor drift with uniform, function-based, or Navier-Stokes coupled velocities.
The current implementation of outlet postprocessors and inlet boundary conditions in
PrecursorAction.C
with function-based velocities and precursor looping:These errors lead to:
Reporter name "Outlet_Average_pre1_/value" with type "double" is not declared.
; andHow to reproduce
Issue 1:
Replace the lines 26-28 in
$MOLTRES/tests/pre/sub.i
:with:
Add the following code block anywhere outside other input sections:
The velocity function imposes the same constant velocity value as the original input file, but the
pre_loop.i
test fails due to the erroneous function-based velocity boundary conditions imposed byPrecursorAction.C
.Issue 2:
In addition to the code changes to reproduce Issue 1, replace line 401 in
PrecursorAction.C
:with:
This step fixes Issue 1 but introduces Issue 2.
How to fix
PrecursorAction.C
as suggested above.PostprocessorInflowBC
, for function-based velocities and fix the inlet boundary condition implementation logic inPrecursorAction.C
.The text was updated successfully, but these errors were encountered: