[DSIP-84][Feature] Add Caché datasource support (#16833) #16844
Conversation
edclol
requested review from
EricGao888,
SbloodyS,
songjianet and
caishunfeng
as code owners
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...java/org/apache/dolphinscheduler/plugin/datasource/cache/param/CacheDataSourceProcessor.java
Fixed
Show fixed
Hide fixed
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
| </dependency> | |
| <dependency> | |
| </dependency> | |
| <dependency> |
| <version>${project.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
|
|
There was a problem hiding this comment.
Did you forget to add the cache jdbc dependency?
There was a problem hiding this comment.
No, I didn't forget. I intentionally didn't add the JDBC dependency because it wasn't available in the Maven repository.
There was a problem hiding this comment.
It must be available in the maven repository and comply with apache protocol or approaching license since DS is an apache software foundation open source project.
There was a problem hiding this comment.
Sorry. Could you check if this one is okay? https://mvnrepository.com/artifact/com.intersystems/cache-jdbc/2.0.0
There was a problem hiding this comment.
It seem like this artifact haven't been updated more than 4 years. And it does not indicate compliance with any open source protocols.
There was a problem hiding this comment.
It seems that this cache database isn't really up to the mark. I don't want all my efforts to go to waste. So, I'll modify the code to make it compatible with the new version of the iris database. Is this okay? https://mvnrepository.com/artifact/com.intersystems/intersystems-jdbc
There was a problem hiding this comment.
Cache is the predecessor of IRIS. However, we do indeed use this old version of the Cache database.😒
There was a problem hiding this comment.
Cache is the predecessor of IRIS. However, we do indeed use this old version of the Cache database.😒
This doesn't comply with apache regulations.
|
Purpose of the pull request
Add Caché datasource support to DolphinScheduler
close #16833
Brief change log
Added Caché constants in DataSourceConstants.java: JDBC driver class: com.Caché.jdbc.Driver; Validation query: "select 1"; JDBC URL prefix: jdbc:Cache://
Added Caché in DbType.java:
CACHE(26, "cache")
Added Caché in use-form.ts:
Added Caché in use-datasource.ts:
3、Configuration:
Added Caché datasource module to the build
Added documentation links in docsdev.js for both English and Chinese
4、Added new files:
Caché datasource implementation classes
Test classes for Caché datasource
UI related changes for Caché support
Verify this pull request
This change added tests and can be verified as follows:
Unit Tests
Test Caché datasource connection parameters validation
Test Caché connection creation and pooling
Test JDBC driver loading and configuration
Test datasource processor functionality
Test channel factory implementation
Test utility methods for Caché datasource
Connection Testing
Test successful connection establishment with valid credentials
Test connection failure with invalid credentials
Test connection timeout scenarios
Test connection pool behavior
Test connection string parameter variations
Query Testing
Test basic SELECT queries
Test complex queries with joins
Test query execution with different data types
Test query timeout scenarios
Test query error handling
UI Testing
Verify Caché datasource form rendering
Test form validation for required fields
Test connection testing functionality from UI
Verify proper display of connection status
Test datasource creation workflow
Test datasource editing functionality
Test datasource deletion
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md