-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Remove redundant and security vulnerable code #15204
base: dev
Are you sure you want to change the base?
[Improvement] Remove redundant and security vulnerable code #15204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15204 +/- ##
============================================
- Coverage 37.81% 37.55% -0.26%
+ Complexity 4680 4600 -80
============================================
Files 1304 1298 -6
Lines 44932 44592 -340
Branches 4810 4765 -45
============================================
- Hits 16989 16745 -244
+ Misses 26094 26028 -66
+ Partials 1849 1819 -30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do we have any related docs to remove? |
Good catch, on the way : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also remove the mapper and sql definitions
Just figured out in spark / flink tasks, there are still places using cluster management stuff. I need to refactor related code to completely get rid of k8s management stuff. |
Kudos, SonarCloud Quality Gate passed! |
Thanks for cleaning this kind of code. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
NO stale |
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
Purpose of the pull request
K8S connection
inConnection(Datasource) Center
to submit task to K8S clusters. There is absolutely no need to have a K8S cluster management console in Dolphin, which only leads to potential vulnerabilities.Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md