Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Remove redundant and security vulnerable code #15204

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

EricGao888
Copy link
Member

@EricGao888 EricGao888 commented Nov 22, 2023

Purpose of the pull request

  • Remove redundant and potentially risky code.
  • Users could use K8S connection in Connection(Datasource) Center to submit task to K8S clusters. There is absolutely no need to have a K8S cluster management console in Dolphin, which only leads to potential vulnerabilities.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly security labels Nov 22, 2023
@EricGao888 EricGao888 added this to the 3.2.1 milestone Nov 22, 2023
@EricGao888 EricGao888 self-assigned this Nov 22, 2023
@EricGao888 EricGao888 changed the title [Improvement][Security] Remove redundant and security vulnerable code [Improvement] Remove redundant and security vulnerable code Nov 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b6b0ce) 37.81% compared to head (4316f2d) 37.55%.

❗ Current head 4316f2d differs from pull request most recent head 4373053. Consider uploading reports for the commit 4373053 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15204      +/-   ##
============================================
- Coverage     37.81%   37.55%   -0.26%     
+ Complexity     4680     4600      -80     
============================================
  Files          1304     1298       -6     
  Lines         44932    44592     -340     
  Branches       4810     4765      -45     
============================================
- Hits          16989    16745     -244     
+ Misses        26094    26028      -66     
+ Partials       1849     1819      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EricGao888 EricGao888 marked this pull request as ready for review November 22, 2023 09:54
@github-actions github-actions bot added the UI ui and front end related label Nov 22, 2023
SbloodyS
SbloodyS previously approved these changes Nov 22, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions bot added the e2e e2e test label Nov 22, 2023
@kezhenxu94
Copy link
Member

Do we have any related docs to remove?

@EricGao888
Copy link
Member Author

Do we have any related docs to remove?

Good catch, on the way : )

kezhenxu94
kezhenxu94 previously approved these changes Nov 22, 2023
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove the mapper and sql definitions

@EricGao888 EricGao888 marked this pull request as draft November 22, 2023 12:53
@EricGao888
Copy link
Member Author

Just figured out in spark / flink tasks, there are still places using cluster management stuff. I need to refactor related code to completely get rid of k8s management stuff.

Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ruanwenjun
Copy link
Member

Thanks for cleaning this kind of code.

Copy link

sonarcloud bot commented Dec 24, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label May 25, 2024
@EricGao888
Copy link
Member Author

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

NO stale

@github-actions github-actions bot removed the Stale label May 28, 2024
@SbloodyS SbloodyS removed this from the 3.2.1 milestone Aug 13, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend document e2e e2e test improvement make more easy to user or prompt friendly Stale UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants