-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add airflow config lint
cli command for lint the configuration changes from Airflow 2.x to Airflow 3.0
#44908
base: main
Are you sure you want to change the base?
Conversation
cbc6eab
to
f5b1798
Compare
f5b1798
to
6800d94
Compare
NAAAAJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks really nice!
@sunank200 one comment but thats just a thought. Will it also be possible to add a short README or so in order for someone to deprecate any future options? (Although i think all are done)
return lint_message | ||
|
||
|
||
CONFIGS_CHANGES = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we can get these dynamically instead?
We have newsfragments which can be the source. Just a thought to make this more manageable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rather the opposite - if anything - those values here shoudl be the "source of truth" - and we could generate release notes for 3.0 from those - we already deleted a number of those deprecations from config I think, so this will be hte only place eventually where those configs will be stored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that makes sense. It was a thought I wanted to throw in. But I realised now that we have deprecated all that we should and so this serves well
6800d94
to
2a9f820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :)
Readme for in how to deprecate options in future? @amoghrajesh can you elaborate on this, please |
… changes from Airflow 2.x to Airflow 3.0
41b5498
to
b3abb24
Compare
This PR introduces the
airflow config lint
command as part of the Airflow CLI config commands for migration tooling for Airflow 3.0. The purpose of this command is to help users transition from Airflow 2.x to 3.0 by identifying and providing actionable feedback on removed and renamed configuration parameters.Implementation details:
CLI Usage Examples:
Lint all sections and options:
Lint a specific section:
Lint a specific section and option:
Ignore a specific section during linting:
Ignore a specific option during linting:
Enable verbose output for detailed feedback:
closes: #44555
related: #41641
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.