AIP-72: Pass context keys from API Server to Workers #44899
Draft
+297
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
force-pushed
the
task-context-api-server
branch
from
0dda9cd to
c751760
Compare
kaxil
force-pushed
the
task-context-api-server
branch
from
c751760 to
ef7be4c
Compare
ashb
reviewed
Dec 13, 2024
|
|
||
| # TODO: `dag_id` and `run_id` are duplicated from TaskInstance | ||
| # See if we can avoid sending these fields from API server and instead | ||
| # use the TaskInstance data to get the DAG run information in the client (Task Execution Interface). |
| class TIRunContext(BaseModel): | ||
| """Response schema for TaskInstance run context.""" | ||
|
|
||
| dag_run: DagRun |
There was a problem hiding this comment.
I would have put this on the TI object, not in here, but potato potato
There was a problem hiding this comment.
Oh, except it's not available/required in the TI start context (which is just the uuid and the 4/5-tuple). Right.
| @@ -48,6 +51,108 @@ | |||
| log = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| @router.patch( | |||
| "/{task_instance_id}/run", | |||
There was a problem hiding this comment.
Maybe
Suggested change
| "/{task_instance_id}/run", | |
| "/{task_instance_id}/start", |
There was a problem hiding this comment.
Thinking more about this, maybe run is better, as this could be called more than once in the case of things like reschedule couldn't it? (Yes, it's just naming so it doesn't matter, but names also do matter)
Comment on lines
+88
to
+92
| ds = logical_date.strftime("%Y-%m-%d") | ||
| ds_nodash = ds.replace("-", "") | ||
| ts = logical_date.isoformat() | ||
| ts_nodash = logical_date.strftime("%Y%m%dT%H%M%S") | ||
| ts_nodash_with_tz = ts.replace("-", "").replace(":", "") |
| @@ -48,9 +48,13 @@ class RuntimeTaskInstance(TaskInstance): | |||
| model_config = ConfigDict(arbitrary_types_allowed=True) | |||
|
|
|||
| task: BaseOperator | |||
| _ti_context_from_server: TIRunContext | None = None | |||
| """The Task Instance context from the API server, if any.""" | |||
There was a problem hiding this comment.
Lets exclude this from the repr I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #44481
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.