AIP-84 add external dependencies asset condition #44877
Open
+246
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
pierrejeambrun
force-pushed
the
AIP-84-add-external-dependencies-asset-condition
branch
2 times, most recently
from
e829bb6 to
ef8d8fe
Compare
pierrejeambrun
force-pushed
the
AIP-84-add-external-dependencies-asset-condition
branch
from
ef8d8fe to
1dd994c
Compare
pierrejeambrun
commented
Dec 13, 2024
There was a problem hiding this comment.
I just want to confirm that it's expected for assets and asset-alias to appear as 'upstream' of the asset-condition. It should be consistent with the getUpstreamAssets but I just want to make sure.
(Then I make the asset condition upstream of the first node of the graph which sounds normal).
Yes, that sounds right to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #44701.
Only last commit is relevant. Add
asset-conditionjoin nodes.Closes: #42367