Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete Attribute Not Disabled for Password Fields in Login Forms #44019

Open
1 of 2 tasks
MarBed190 opened this issue Nov 14, 2024 · 4 comments · May be fixed by #44929
Open
1 of 2 tasks

Autocomplete Attribute Not Disabled for Password Fields in Login Forms #44019

MarBed190 opened this issue Nov 14, 2024 · 4 comments · May be fixed by #44929
Assignees
Labels
kind:feature Feature Requests security Security issues that must be fixed

Comments

@MarBed190
Copy link

Description

Currently, the password input fields in Apache Airflow's login forms do not have the autocomplete attribute set to off. This allows browsers to store passwords entered by users, which poses a potential security risk—especially when accessing Airflow from shared or public computers. To enhance security and adhere to best practices for handling sensitive information, the autocomplete attribute should be disabled for all password fields in form-based authentication.

Use case/motivation

As an employee responsible for the security of our corporate IT systems that utilize Apache Airflow, I want to enhance the protection of user credentials by disabling the autocomplete feature on password fields. This change will make our systems more secure for all users by preventing browsers from storing sensitive passwords, which could be exploited if a device is compromised or shared. Additionally, implementing this fix will ensure that our automated security scanners no longer flag this issue, helping us maintain compliance with our organization's security policies and reducing the overhead of managing reported vulnerabilities.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@MarBed190 MarBed190 added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Nov 14, 2024
Copy link

boring-cyborg bot commented Nov 14, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@dosubot dosubot bot added the security Security issues that must be fixed label Nov 14, 2024
@geraj1010
Copy link
Contributor

geraj1010 commented Nov 17, 2024

I think it might just be an update to airflow/www/forms.py. I did find a SO https://stackoverflow.com/questions/20326511/how-to-avoid-password-being-auto-filled, on turning autocomplete off. However, I'm not sure if this solution is still valid, since apparently Chrome may ignore the setting.

I might be interested in this :)

@romsharon98 romsharon98 removed the needs-triage label for new issues that we didn't triage yet label Nov 22, 2024
@amoghrajesh
Copy link
Contributor

I think this is something that can be worth fixing to improve the security posture of airflow.

Feel free to work on this @geraj1010

cc @bbovenzi

@geraj1010
Copy link
Contributor

@amoghrajesh Okay sounds good.
I was off on what I thought needed to be updated. I think it's actually www/static/js/login/Forms.tsx

geraj1010 added a commit to geraj1010/airflow that referenced this issue Dec 9, 2024
…f for username and password input elements on AUTH_DB login page
geraj1010 added a commit to geraj1010/airflow that referenced this issue Dec 13, 2024
geraj1010 added a commit to geraj1010/airflow that referenced this issue Dec 14, 2024
@geraj1010 geraj1010 linked a pull request Dec 14, 2024 that will close this issue
jscheffl pushed a commit to geraj1010/airflow that referenced this issue Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature Feature Requests security Security issues that must be fixed
Projects
None yet
4 participants