Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git bash windows fzf error #382

Open
cloud-66 opened this issue Mar 3, 2023 · 4 comments
Open

git bash windows fzf error #382

cloud-66 opened this issue Mar 3, 2023 · 4 comments

Comments

@cloud-66
Copy link

cloud-66 commented Mar 3, 2023

image

Never mind how kubectx (golang version) installed, by downloading binary or by scoop
kubectx (Enter)
it works in powershell, but don't in git bash for windows. I guess because path should be in bash format /c/Users/Cloud/scoop/shims/kubectx

@ahmetb
Copy link
Owner

ahmetb commented Mar 3, 2023

Yeah this is an interesting case. We pass kubectx's full path to fzf, I wonder if we should if-else this for mingw.

@mloskot
Copy link

mloskot commented Apr 6, 2023

I'm observing the same problem while running kubectx in Git Bash session in Windows Terminal:

image

but if I switch to PowerShell in the same Windows Terminal, then it works:

image

If I switch to plain Start > Git Bash, and not in Windows Terminal, then everything works:

image

Environment: I tend to install everything with winget:

$ kubectx --version
0.9.4
$ fzf --version
0.39.0 (2023040)

I'm observing the same problem with kubens. See also #307

@mloskot
Copy link

mloskot commented Apr 7, 2023

Update to my #382 (comment)

In Git Bash in Windows Terminal, interestingly, if I pipe kubectx | fzf:

image

then I get no error, but this

image

But, selecting context and ENTER seems to have no effect.

@mloskot
Copy link

mloskot commented Apr 13, 2023

@cloud-66 See #330 (comment) for working workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants