Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading of fcsv agnostic to AFID order #44

Open
ataha24 opened this issue Sep 30, 2023 · 4 comments
Open

Loading of fcsv agnostic to AFID order #44

ataha24 opened this issue Sep 30, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@ataha24
Copy link

ataha24 commented Sep 30, 2023

I am trying to load an fcsv file which has some "jumbled" ordering of AFIDs (i.e., AFID 19 placed at 4th position but still contains the correct label). The load method seems to fail due to that (see attached screenshot). Perhaps creating a load method with some agnostic features to the loaded file may be a good thing to include.
Screenshot 2023-09-30 at 7 29 27 PM

@ataha24 ataha24 added the enhancement New feature or request label Sep 30, 2023
@tkkuehn
Copy link
Contributor

tkkuehn commented Oct 2, 2023

Can you post the FCSV in question here?

If I'm understanding correctly, it had label 19, and desc Genu of CC, but because it wasn't the 19th row in the FCSV, the load method failed. I think it would make sense to support that case.

@kaitj
Copy link
Contributor

kaitj commented Oct 18, 2023

Just out of curiosity, @ataha24, was this installed via pip or was this a local install? If this was pip, it would be using v0.1.0 instead of the v0.2.0-pre-15.

I might be misremembering, but I didn't think it was using the rows to validate, and was using the label provided. As Tristan had mentioned, it would be good to post the FCSV in question so we can do a more in depth debug.

@ataha24
Copy link
Author

ataha24 commented Oct 18, 2023

This was indeed with pip install!

@kaitj
Copy link
Contributor

kaitj commented Oct 18, 2023

I editted the previous comment with a bit more detail, but just to reiterate, if you could post (or send) the fcsv in question, we can do a more in depth debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants