Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Package @atakansn/adonisjs-maintenance-mode #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atakansn
Copy link

@atakansn atakansn commented Oct 28, 2024

Maintenance mode package for AdonisJS 6.

@atakansn atakansn changed the title Add Package atakansn/adonisjs-maintenance-mode Add Package @atakansn/adonisjs-maintenance-mode Oct 28, 2024
@Julien-R44
Copy link
Collaborator

We already have a maintenance mode package here: https://github.com/MichaelBelgium/adonisjs-maintenance.

Im still not sure how to handle this situation. The goal is to avoid spreading the community too much multiple similar packages. Are there any significant differences between the two? At first glance, yours seems more feature-rich.

@MichaelBelgium @atakansn, would it make sense for you both to coordinate so we can consolidate into a single package? Ideally, merging the two if one is missing specific features. This way, we can focus community efforts on the same packages rather than creating numerous variations.

It might make sense to have two different packages, but in this specific case, I don't think so.

@Julien-R44 Julien-R44 added the pending Awaiting PR author for some information/modifications label Nov 30, 2024
@atakansn
Copy link
Author

atakansn commented Dec 2, 2024

Yes, I can merge if the current package owner agrees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Awaiting PR author for some information/modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants