Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio and new Cli are not using the latest template #21062

Open
1 task done
renping106 opened this issue Oct 12, 2024 · 3 comments
Open
1 task done

Studio and new Cli are not using the latest template #21062

renping106 opened this issue Oct 12, 2024 · 3 comments
Labels

Comments

@renping106
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

There are differences in the program.cs file created by new cli and old cli. Template is app.
Let‘s compare the program.cs file in project MyProjectName.Web.
New cli:
image
Old cli:
image

Reproduction Steps

  1. Create a new project by old cli.
    abp new Acme.BookStore -m none --theme leptonx-lite -csf --old
  2. Create a new project by new cli.
    abp new Acme.BookStore -m none --theme leptonx-lite -csf
  3. Compare the program.cs in MyProjectName.Web

Expected behavior

program.cs should be the same.

Actual behavior

They are different. Looks like the new cli is using a template with a very old version.

Regression?

No response

Known Workarounds

No response

Version

8.3.1

User Interface

Common (Default)

Database Provider

EF Core (Default)

Tiered or separate authentication server

None (Default)

Operation System

Windows (Default)

Other information

No response

@renping106 renping106 added the bug label Oct 12, 2024
@improwise
Copy link
Contributor

There are other differences also it seems, like the old CLI having full support for Docker while the new one (or rather solutions created with it and ABP Studio) has almost none. Folder structure etc. is also different. All in all there seem to be a substantial amount of differences between two created solutions both using respective 8.3.1 CLI.

We are using the commercial version of ABP, so there might be differences compared to the open source one, but with the base being the same for both, most of them should be the same I think.

@RobertoFiocchiMCSI
Copy link

I think so too, in fact I had already opened a similar issue
#20388

Abp teaches us to apply the DRY method (don't repeat yourself) and I don't think that having two distinct templates is a winning solution.
It requires double the maintenance and testing work for volosoft and for me.
The version for Abp Studio comes out too many days late compared to the open source.
I think VoloSoft should review this management.
Thanks

@ejohnson-dotnet
Copy link
Contributor

I also had a similar issue #21592.

The new template had the line options.FileSets.AddEmbedded<MyProjectWebModule>(); in it but the old template did not.

Also, why are the new templates not open source like the old templates?

The source code of the old templates is here: https://github.com/abpframework/abp/tree/dev/templates

Where is the source code for the new templates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants